Skip to content

Improve unskipping support - #53

Merged
ErikSchierboom merged 2 commits into
mainfrom
support-all-attributes
Nov 17, 2021
Merged

ErikSchierboom merged 2 commits into
mainfrom
support-all-attributes

Conversation

@ErikSchierboom

@ErikSchierboom ErikSchierboom commented Nov 17, 2021 •

Copy link
Copy Markdown
Member
  • Unskip all types of attributes
  • Don't remove custom attributes

@martinfreedman As we've had more complaints about the diamond exercise being broken, I've gone ahead and implemented this. As you have already spent time working on this, I think it's fair for you to do the actual PR, to award you the proper reputation. You can just cherry-pick the commits from this PR in your own PR.

Closes #36 (comment)
Closes #33

@ErikSchierboom
ErikSchierboom requested a review from a team as a code owner November 17, 2021 13:39
@ErikSchierboom
ErikSchierboom requested a review from iHiD November 17, 2021 13:39
@ErikSchierboom
ErikSchierboom marked this pull request as draft November 17, 2021 13:40
@martinfreedman

Copy link
Copy Markdown

Thank you @ErikSchierboom - all very complex on the home front with illness - I need to create a new PR and then refer to this one?

@ErikSchierboom
ErikSchierboom marked this pull request as ready for review November 17, 2021 14:25
@ErikSchierboom
ErikSchierboom merged commit 1f27ac9 into main Nov 17, 2021
@ErikSchierboom
ErikSchierboom deleted the support-all-attributes branch November 17, 2021 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

'Diamond' test run fails without error message Unskip all types of tests

3 participants