test-without-stubs,exercises: Typo fixes - #570
Merged
Merged
Conversation
ferhatelmas
commented
Mar 6, 2017
ferhatelmas
commented
Contributor
- used https://github.com/client9/misspell
Contributor
Author
|
We might want to add this into CI but not sure because we can get false positives. What do you think ? |
tleen
approved these changes
Mar 7, 2017
Member
|
If changes would be rejected because of false positives it sort of has to be a no? We shouldn't have things fail if they are correct. I do think running this process occasionally would help tighten things up. |
Contributor
Author
|
I agree. |
Contributor
|
Is it worth adding a note somewhere, perhaps the README, about this, so it doesn't get lost here? |
Member
|
May be worth pointing out the tool, but effectively it will be up to us to periodically check by using it. |
ferhatelmas
added a commit
that referenced
this pull request
Mar 11, 2017
README.md: Add a note about misspell tool used in #570
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.