Last Will exercise + namespaces#1832
Conversation
The tests for these two learning exercises now check whether the expected exception has been defined inside or outside the main class. Solves issue #6772
The tests for these two learning exercises now check whether the expected exception has been defined inside or outside the main class. Solves issue #6772
…o moviegoer_calculator_fix
kotp
left a comment
There was a problem hiding this comment.
Ensure consistent formatting of the code and the code snippets.
Inspect the reasons for the failing CI tasks/checks.
|
@kotp what do I use for uuid? I need it in two places in config.json (for the new exercise and for the new concept). |
You can use the bin/configlet uuidOf course, you can use any tool that generates Version 4 UUID's. |
@kotp thanks! Where can I find the documentation you mention? I'm pretty sure I've looked through the documents in the repo and didn't see anything about generating UUIDs. |
Start here, and then it is the first thing under Also, just want to mention |
kotp
left a comment
There was a problem hiding this comment.
Looking pretty good to me. I think this will come in unless anyone else has some corrections or concerns.
kotp
left a comment
There was a problem hiding this comment.
Still finding cached artifacts or something in the browser. Going to submit this with the "pending", but will act on the approval when I wake up hoping you saw it and decided...
kotp
left a comment
There was a problem hiding this comment.
I know I said I was going to bring this in, unfortunately, the commit messages include references to exercises that are not involved in Last Will.
You will (very likely) want to rebase interactively and see if you can get the history to be focused on only last-will concept.
If you have to force push your branch, that is fine, and expected.
The final result of this looks good, the history is what is stopping me from bringing it in, since I will have to figure out the story as you would want it to be written in the commit message.
I will reach out to you off-platform in case you need to pair through this process.
Adapted the Last Will exercise from the C++ track and added it to the Ruby learning track, together with the concept of namespaces.