Skip to content

Add CREATE OR REPLACE to default SQL blacklist #720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DangTAnh wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add CREATE OR REPLACE to default SQL blacklist #720

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/settings.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ Disallowed words in SQL queries to prevent destructive actions.
# DDL
'ALTER',
'CREATE',
'CREATE OR REPLACE',
'DROP',
'RENAME',
'TRUNCATE',
Expand Down
1 change: 1 addition & 0 deletions explorer/app_settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
# DDL
"ALTER",
"CREATE",
"CREATE OR REPLACE",
"DROP",
"RENAME",
"TRUNCATE",
Expand Down
5 changes: 5 additions & 0 deletions explorer/tests/test_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,11 @@ def test_ddl_create(self):
passes, words = passes_blacklist(sql)
self.assertFalse(passes)

def test_ddl_create_or_replace(self):
sql = "CREATE OR REPLACE VIEW foo AS SELECT 1;"
passes, words = passes_blacklist(sql)
self.assertFalse(passes)

def test_ddl_drop(self):
sql = "DROP TABLE films, distributors;"
passes, words = passes_blacklist(sql)
Expand Down
Loading