Skip to content

Add GitHub Actions and Jest config - #4

Merged
fson merged 6 commits into
masterfrom
@fson/actions
Sep 16, 2020
Merged

fson merged 6 commits into
masterfrom
@fson/actions

Conversation

@fson

@fson fson commented Sep 15, 2020

Copy link
Copy Markdown
Contributor

No description provided.

@fson
fson requested a review from byCedric September 15, 2020 17:35
Comment thread .github/workflows/test.yml Outdated
- uses: actions/cache@v1
id: cache-build
with:
path: "."

@byCedric byCedric Sep 15, 2020 •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know we use this approach to run tests for the CLI in parallel, it might be faster in this project to install and test everything at once (within 1 job)? It definitely would reduce the cache sizes 😄

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, and I think this could be better in terms of KISS, YAGNI and YAML too 😄

@fson
fson merged commit d704430 into master Sep 16, 2020
@fson
fson deleted the @fson/actions branch September 16, 2020 09:06
szdziedzic added a commit that referenced this pull request Oct 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants