Skip to content

Fixed fable-compiler-js build - #2150

Closed
ncave wants to merge 1 commit into
fable-compiler:nagareyamafrom
ncave:fix2
Closed

ncave wants to merge 1 commit into
fable-compiler:nagareyamafrom
ncave:fix2

Conversation

@ncave

@ncave ncave commented Sep 5, 2020 •

Copy link
Copy Markdown
Collaborator

Was missing System.Web.HttpUtility.dll

@alfonsogarciacaro

Copy link
Copy Markdown
Member

Good catch, thank you! Hmm, I'm now thinking if adding a new dll dependency to fable-js only to have access to that method is a good idea. Maybe we can pass it as a platform dependency, we have to do it for the writer anyways. What do you think? 6401e50#diff-65e59101fe6c6bd675ab418f704fb8f4R17

@ncave

ncave commented Sep 6, 2020

Copy link
Copy Markdown
Collaborator Author

@alfonsogarciacaro System.Web.HttpUtility.dll is a very small DLL, so it's fine. But if you prefer it as a platform dependency, that's fine too.

@ncave

ncave commented Sep 11, 2020

Copy link
Copy Markdown
Collaborator Author

Closing as obsolete.

@ncave ncave closed this Sep 11, 2020
@ncave
ncave deleted the fix2 branch September 12, 2020 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants