Repository navigation
Conversation
dbrattli
marked this pull request as ready for review
October 3, 2026 22:45
Base automatically changed from
fix/cancellation-registration-lifecycle
to
main
October 10, 2026 15:26
Contributor
Python Type Checking Results (Pyright)
Excluded files with errors (4 files)These files have known type errors and are excluded from CI. Remove from
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Python
Async.Sleepdiscards its scheduled handle, so cancellation can later be followed by timeout success and a second finalizer. The cancellation guard also falls through and executes already-cancelled work. JS leaves cancelled-sleep listeners installed, and both runtimes mishandle throwing finalizers during cancellation. Executed .NET references confirm that cancellation stays terminal even if its finalizer throws.The regressions belong in the existing F# async suites so they exercise generated computations and share public behavior checks with .NET. Native fixtures provide deterministic scheduler and thread controls through the suites' established interop pattern.
How
tests/Python/TestAsync.fsandtests/Js/Main/AsyncTests.fs. Import scheduler/thread fixtures fromtests/Python/py/async_runtime.pyandtests/Js/Main/js/async-runtime.js; remove the standalone JS runner and its build hook.