Repository navigation
fix(beam): normalize exception messages and string split separators - #5053
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEAM custom exceptions with numeric or union payloads expose
Messageas a raw Erlang value. String consumers andAggregateExceptionformatting then fail withbadarg. RouteSystem.Exception.Messagethrough a binary-producing runtime helper while preserving the original payload fields and existing string messages.The string-consumer regressions also expose inconsistent
String.Splitseparator normalization. A separate commit normalizes character and string separator arrays for plain, remove-empty, and count-limited splits.Validation:
./build.sh test beam --force-fable-library: 2,736 .NET and 2,788 BEAM tests passed, including entry-point and compiler-diagnostic checks.badargon the original BEAM runtime; three separator scenarios also reproducebadargbefore the fix.git diff --checkpassed.