This repository was archived by the owner on Feb 2, 2023. It is now read-only.
[ASDataController] Revert the reloadData optimizations again - need to fix apps relying on prior behavior. - #1253
Merged
appleguy merged 1 commit intoFeb 20, 2016
Conversation
…oadData and reloadSection: methods."""
appleguy
added a commit
that referenced
this pull request
Feb 20, 2016
…-1171-ASDataController-reload [ASDataController] Revert the reloadData optimizations again - need to fix apps relying on prior behavior.
appleguy
deleted the
revert-1249-revert-1247-revert-1171-ASDataController-reload
branch
February 20, 2016 07:28
aimalygin
pushed a commit
to aimalygin/AsyncDisplayKit
that referenced
this pull request
Dec 27, 2018
* fix SIMULATE_WEB_RESPONSE not imported facebookarchive#449 * Fix to make rangeMode update in right time * remove uncessary assert * Fix collection cell editing bug for iOS 9 & 10 * Revert "Fix collection cell editing bug for iOS 9 & 10" This reverts commit 06e18a10596622ff8a68835c95a23986d7bf61ea. * Add description method for yoga. * Fix comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The optimization seems correct now, but apps like Pinterest have some core code relying on edit operation
order that is actually not permitted by UIKit (and this diff) but were tolerated previously. We will
re-land this once we have time to adapt the code.
this re-attempts the revert of (a106130), which didn't seem to actually revert the change.
Reverts #1249