This repository was archived by the owner on Feb 2, 2023. It is now read-only.
[ASCollectionView] scrollableDirections must account for alwaysBounce(Vertical | Horizontal) - #1327
Merged
appleguy merged 1 commit intoMar 6, 2016
Conversation
Contributor
|
Great improvement! @samhsiung should make sure the ASBatchContext is triggering even without scrolling in a scenario like this, though it is certainly good to ensure the user can force a load. Ideally we would not re-access bounds, contentSize, contentInset properties here - but this is a micro-optimization and not essential. |
appleguy
changed the title
appleguy
added a commit
that referenced
this pull request
Mar 6, 2016
[ASCollectionView] scrollableDirections must account for alwaysBounce(Vertical | Horizontal)
peter-iakovlev
pushed a commit
to peter-iakovlev/AsyncDisplayKit
that referenced
this pull request
Feb 13, 2019
* fix SIMULATE_WEB_RESPONSE not imported facebookarchive#449 * Fix to make rangeMode update in right time * remove uncessary assert * Fix collection cell editing bug for iOS 9 & 10 * Revert "Fix collection cell editing bug for iOS 9 & 10" This reverts commit 06e18a10596622ff8a68835c95a23986d7bf61ea. * fix a11y update when insert view
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a UIScrollVIew has alwaysBounce(Vertical|Horizontal) = YES then it will always be scrollable in that direction. Adding these additional checks will allow us to handle cases where an ASCV without a flow layout has a data source whose first page load doesn't expand contentSize beyond bounds in the desired scroll direction. When the user scrolls in the intended direction, batch fetching will be triggered if there is more content to load.