Skip to content
This repository was archived by the owner on Feb 2, 2023. It is now read-only.

[ASMultidimensionalArrayUtils] Optimization for recursive version, expanded use case of more efficient 2D version #1378

Merged
appleguy merged 1 commit into from
Mar 16, 2016
Merged

[ASMultidimensionalArrayUtils] Optimization for recursive version, expanded use case of more efficient 2D version #1378

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion AsyncDisplayKit/Details/ASRangeController.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ - (void)_updateVisibleNodeIndexPaths
_didUpdateCurrentRange = NO;

if (!_rangeIsValid) {
[allIndexPaths addObjectsFromArray:ASIndexPathsForMultidimensionalArray(allNodes)];
[allIndexPaths addObjectsFromArray:ASIndexPathsForTwoDimensionalArray(allNodes)];
}

// TODO Don't register for notifications if this range update doesn't cause any node to enter rendering pipeline.
Expand Down
10 changes: 6 additions & 4 deletions AsyncDisplayKit/Private/ASMultidimensionalArrayUtils.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,12 @@ static void ASRecursivelyFindIndexPathsForMultidimensionalArray(NSObject *obj, N
if (![obj isKindOfClass:[NSArray class]]) {
[res addObject:curIndexPath];
} else {
NSArray *arr = (NSArray *)obj;
[arr enumerateObjectsUsingBlock:^(NSObject *subObj, NSUInteger idx, BOOL *stop) {
ASRecursivelyFindIndexPathsForMultidimensionalArray(subObj, [curIndexPath indexPathByAddingIndex:idx], res);
}];
NSArray *array = (NSArray *)obj;
NSUInteger idx = 0;
for (NSArray *subarray in array) {
ASRecursivelyFindIndexPathsForMultidimensionalArray(subarray, [curIndexPath indexPathByAddingIndex:idx], res);
idx++;
}
}
}

Expand Down