This repository was archived by the owner on Feb 2, 2023. It is now read-only.
[ASDisplayNode] Placeholders should always be recreated if returning to cleared nodes. - #1398
Merged
Conversation
…to past nodes. If previously-displayed contents is gone (e.g. clearContents), and is not finished displaying by the time the node is onscreen, recreate the placeholder immediately.
Contributor
Author
|
@maicki @garrettmoon (ASImageNode changes) @nguyenhuy it would be great to have a review from one or two of you. Until then, I am going to go ahead and land this, so that I can get increased test coverage over the weekend as I continue to do development on other branches that I would like to rebase with this change. |
appleguy
added a commit
that referenced
this pull request
Mar 20, 2016
[ASDisplayNode] Placeholders should always be recreated if returning to cleared nodes, and remain until ASNetwork/MultiplexImageNode finish loading their image from the network.
Contributor
Author
|
cc @Adlai-Holler regarding the change for multiplex. Note that placeholder fading out now works reliably as well. |
| [CATransaction begin]; | ||
| [CATransaction setDisableActions:YES]; | ||
| [self _setupPlaceholderLayerIfNeeded]; | ||
| _placeholderLayer.opacity = 1.0; |
Contributor
There was a problem hiding this comment.
Are we sure that the placeholder is always opaque?
Contributor
|
@appleguy Added one small comment but LGTM |
Contributor
|
Love this! Nice @appleguy! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If previously-displayed contents is gone (e.g. clearContents), and is not finished displaying
by the time the node is onscreen, recreate the placeholder immediately.