This repository was archived by the owner on Feb 2, 2023. It is now read-only.
Export ASThread to unbreak the subclass header files - #4
Merged
Conversation
Contributor
Author
|
Hold up - found a bug in this - I tested by compiling a project that installed it but not the project itself. Will update soon with a better diff. |
Summary: * Moves ASThread.h from Private to Public visibility * Moves ASThread.h from Private/ to Details/ * Changes public #imports from "" to <> Test Plan: ``` #import <AsyncDisplayKit/ASDisplayNode+Subclasses.h> #import <AsyncDisplayKit/ASControlNode+Subclasses.h> ```
Contributor
Author
|
Okay, updated. looks OK to me, for now. |
secretiverhyme
added a commit
that referenced
this pull request
Jul 17, 2014
Export ASThread to unbreak the subclass header files
Contributor
|
Unit tests build and pass. Test project that depends on AsyncDisplayKit still builds. r=me |
nguyenhuy
pushed a commit
to nguyenhuy/AsyncDisplayKit
that referenced
this pull request
Apr 18, 2017
* Rename AsyncDisplayKit to Texture * More renaming
aimalygin
pushed a commit
to aimalygin/AsyncDisplayKit
that referenced
this pull request
Apr 18, 2017
* Rename AsyncDisplayKit to Texture * More renaming
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should work for making AsyncDisplayNode+Subclasses.h work.
Verifying other changes to other header files, but this is a good first step I think.