Skip to content
This repository was archived by the owner on Feb 2, 2023. It is now read-only.

Actually coalesce calls to updateVisibleNodeIndexPaths - #569

Closed
eanagel wants to merge 1 commit into
facebookarchive:masterfrom
eanagel:fix-coalesce
Closed

Actually coalesce calls to updateVisibleNodeIndexPaths#569
eanagel wants to merge 1 commit into
facebookarchive:masterfrom
eanagel:fix-coalesce

Conversation

@eanagel

@eanagel eanagel commented Jul 13, 2015

Copy link
Copy Markdown
Contributor

No description provided.

@appleguy

Copy link
Copy Markdown
Contributor

@eanagel I think we discussed this one in person — this should not be necessary due to the boolean flag that is checked earlier in the method, correct? In what scenario could the performSelector: be queued up multiple times? Note that calling cancel and perform again incurs some additional cost, so it is net preferred if it can be avoided.

@eanagel

eanagel commented Jul 15, 2015

Copy link
Copy Markdown
Contributor Author

Oh yeah! I see that now. Closing.

@eanagel eanagel closed this Jul 15, 2015
@eanagel
eanagel deleted the fix-coalesce branch July 15, 2015 17:13
fruitcoder pushed a commit to digitalegarage/AsyncDisplayKit that referenced this pull request Oct 9, 2017
* fix SIMULATE_WEB_RESPONSE not imported facebookarchive#449

* update yoga version
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants