This repository was archived by the owner on Feb 2, 2023. It is now read-only.
Substantially improve behavior of nested Table & Collection Nodes - #847
Merged
Conversation
This ensures memory cleanup happens correctly and introduces a new test project to support developing new features while stressing tough use cases for correctness.
appleguy
added a commit
that referenced
this pull request
Nov 15, 2015
Substantially improve behavior of nested Table & Collection Nodes
peter-iakovlev
pushed a commit
to peter-iakovlev/AsyncDisplayKit
that referenced
this pull request
Jul 21, 2018
…ial (facebookarchive#847) * fix SIMULATE_WEB_RESPONSE not imported facebookarchive#449 * Fix to make rangeMode update in right time * This is for cases when CollectionNode is created in cell of another collectionNode, the interfaceState(say didEnterVisible) is not called as expected. It's because interfaceCoalescing alter the time line and cause RangeController update before actual interface applied.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures memory cleanup happens correctly and introduces a new test project
to support developing new features while stressing tough use cases for correctness.
Debugged an issue where setting the frame on as ASTableNode is not equivalent to setting the frame on that node's view. UITableView apparently depends on setFrame: being called directly on the view instance, and is not able to tolerate setBounds: + setPosition: called on its layer; one of its subviews is never resized in this case. To be safe, I've revised the frame setting process to not use the bounds / position implementation (which is a convenience to enable setting frames with non-identity transforms) for nodes that wrap synchronous UIViews, like ASTableNode, ASCollectionNode, ASScrollNode, and any third-party node created with initWithViewBlock:.