This repository was archived by the owner on Feb 2, 2023. It is now read-only.
Trigger a relayout once the media image of PostNode in SocialAppLayout is loaded - #857
Merged
appleguy merged 1 commit intoNov 29, 2015
Conversation
Contributor
|
@nguyenhuy I'm biMawa (Maxim) :P . And yea i see that too i forgot say about that. |
Contributor
Author
|
Oops, sorry for the mistake :( Edited |
Contributor
|
No problem ;) |
Contributor
|
@nguyenhuy Thanks for the fix. This code is a little hard to understand, however - certainly as an author, it would be a bit of a struggle to write. Is there any way you can think of to trigger this automatically? Should the image node simply mark itself as needing layout, because I am nearly certain that once the layout pass runs, that will make the supernode perform a layout? This would be ideal solution, if feasible. |
appleguy
added a commit
that referenced
this pull request
Nov 29, 2015
Trigger a relayout once the media image of PostNode in SocialAppLayout is loaded
peter-iakovlev
pushed a commit
to peter-iakovlev/AsyncDisplayKit
that referenced
this pull request
Jul 21, 2018
…#857) * Make NSIndexSet+ASHelpers.h reference local NSIndexSet+ASHelpers.h should be a user vs a system or framework include. * Update ASIntegerMap.mm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was looking for a sample code to answer @bimawa's question in #855 when I found out that, although a reserve-image-ratio logic is available in PostNode of SocialAppLayout example, it isn't used. No use no more :)