This repository was archived by the owner on Feb 2, 2023. It is now read-only.
Add a Reset Method to RangeController, Use In reloadData - #862
Closed
Adlai-Holler wants to merge 1 commit into
Closed
Add a Reset Method to RangeController, Use In reloadData#862Adlai-Holler wants to merge 1 commit into
Adlai-Holler wants to merge 1 commit into
Conversation
Contributor
Author
|
Suspect the problem is more general than this, see #861 for discussion. |
peter-iakovlev
pushed a commit
to peter-iakovlev/AsyncDisplayKit
that referenced
this pull request
Jul 21, 2018
* fix SIMULATE_WEB_RESPONSE not imported facebookarchive#449 * Fix to make rangeMode update in right time * disable interface coalescing and fix tests * Revert to before coalescing for ease of reading * refactor, make min change * refactor * add comments * Add change log
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pursuant to #861, here's my attempt at a fix. It resolves the issues I'm having with nodes not always getting
fetchDatapost-reloadDatabut I'm hardly an expert on ASRangeController. I threw in the main thread assertion kind of willy-nilly to be honest.