AP2: New create and upload endpoints to create restricted media - #89
Merged
Conversation
itsoyou
force-pushed
the
syk/msc3911-unstable-endpoint
branch
3 times, most recently
from
August 24, 2025 20:35
0634d28 to
18bdf34
Compare
itsoyou
marked this pull request as ready for review
August 24, 2025 20:35
itsoyou
changed the title
itsoyou
force-pushed
the
syk/msc3911-unstable-endpoint
branch
from
August 28, 2025 08:46
213606d to
c5e1337
Compare
nico-famedly
approved these changes
Aug 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Media MSC3911 AP2: New create and upload endpoints to create restricted media #3351
For linking media, we need new endpoints to create restricted media files:
These are equivalent to the existing create and upload endpoints for media, but create restricted media in a pending state (until the media is attached).
Question
get_local_mediafunction ofGET /_matrix/client/v1/media/download/{server_name}/{media_id}/{filename}endpoint is updated to make sure resource is not accessible to others in pending state. However, I am not sure what to do with remote media case.Acceptance criteria