MSC3911: AP2 - Database preparations and storage helpers - #91
Merged
Conversation
jason-famedly
force-pushed
the
jason/msc3911-sql-schema
branch
from
August 19, 2025 14:21
6a3b632 to
0ccc40c
Compare
jason-famedly
force-pushed
the
jason/msc3911-sql-schema
branch
5 times, most recently
from
August 20, 2025 12:47
5275f90 to
184bc6a
Compare
jason-famedly
marked this pull request as ready for review
August 20, 2025 12:57
Member
Author
|
I guess this is ready. I'm sure I over thought it, but if there are any suggestions for additional tests I'd like to hear those thoughts |
jason-famedly
force-pushed
the
jason/msc3911-sql-schema
branch
from
August 20, 2025 14:57
6e83960 to
c485d30
Compare
Member
Author
|
Since we are now just storing the raw json for the media restrictions, should I keep the media restriction object? I'd like to have that nice type safe way of parsing, but if we are to incorporate unknown restrictions I don't really have a way to model that....unless the object exists but neither of the known restrictions is set? |
itsoyou
reviewed
Aug 22, 2025
jason-famedly
force-pushed
the
jason/msc3911-sql-schema
branch
2 times, most recently
from
August 22, 2025 13:39
178cd8a to
42306da
Compare
itsoyou
approved these changes
Aug 22, 2025
…etrieval of media restrictions
jason-famedly
force-pushed
the
jason/msc3911-sql-schema
branch
from
August 22, 2025 13:46
42306da to
0120afb
Compare
Member
Author
|
The test failures appear to be either known flakes or unrelated to anything that would have happened here. Merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create a new table
media_attachmentsto containserver_namemedia_idrestrictions_jsonAdd a new column to
remote_media_cacheforrestrictedboolean valuesAdd a new column to
local_media_repositoryforrestrictedfor boolean valuesTest series added at
tests.storage.test_mediaLocalMediato have arestrictedboolean objectRemoteMediato have arestrictedboolean objectlocal_media_repositoryto have new columns from description aboveremote_media_cacheto have new columns from description abovemedia_attachmentsbased on table aboveMediaRestrictionsobject to contain anevent_idandprofile_user_id. Do we want this to be validated at this level or have it be validated before creation of the object?MediaRepositoryStore:For: famedly/product-management#3350