Repository navigation
Conversation
Keep TypeScript as a development-only tool so JavaScript consumers no longer receive peer dependency warnings while preserving the package build and typecheck toolchain. Fixes farcasterxyz#17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17
The published client currently requires consumers to provide exactly TypeScript 5.8.3, even though it runs as JavaScript and TypeScript is only needed to build this package. Move the unchanged compiler version from peerDependencies to devDependencies and update its workspace lockfile classification.
This keeps the fix scoped to the client manifest and lockfile. #32 is a broader workspace/dependency rewrite; this PR does not include its unrelated changes.
Validation on the existing branch:
The runtime is Node 24.19.0; the workspace advertises Node 23.x. Tests/build were run with the package npm scripts after dependencies were installed; pnpm 11's install exited on ignored dependency build scripts.