Repository navigation
🐛 Fix silent overwrite of main.py and README.md in current directory mode - #148
Open
Dextheking1 wants to merge 1 commit into
Open
Dextheking1 wants to merge 1 commit into
Dextheking1 wants to merge 1 commit into
Conversation
Dextheking1
marked this pull request as ready for review
October 23, 2026 05:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running
fastapi newwith no arguments (or.) in a directory that already has amain.pyandREADME.mdbut nopyproject.tomloverwrites both files with the hello world template. No warning, no backup.Subdirectory mode already refuses to touch an existing directory. Current directory mode had no check at all for the two files it writes.
Fix: in current directory mode, refuse to run when
main.pyorREADME.mdalready exist, with an error naming them.Test:
test_refuses_to_overwrite_existing_files_in_current_dirwrites marker files, runs the CLI with no arguments, and asserts exit code 1 plus both files unchanged. It fails on current main (exit code 0, files replaced) and passes with this fix.