You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Diagnostics capture in the migrated composer bypasses the redaction/retention boundary (from #781) #890
Carried forward from #781, which was merged with these unresolved rather than held. Not defects in the cookie-bar fix itself (that is measured and wanted) — they are in the diagnostics machinery bundled alongside it.
1. Occluder reports reach a user-facing message unredacted
_verify_submit_target interpolates the blocking element into UiSelectorDriftError.detail, carrying the element's raw id and up to 160 characters of className. No raise site calls redact_sensitive_text.
#778 introduced a closed allowlist for exactly this data on exactly this page — tag plus at most three framework class tokens — because a signed-in Flow page carries account identifiers on these elements. Truncating to 160 characters bounds the size, not the contents. Route the occluder report through that allowlist.
2. Failure screenshots land in the user's plain output directory
_capture_ui_failure writes to out_dir / "ui-failures", ungated by incident_capture. ui_automation_video.py:756 refuses this by name:
outside the bundle's sensitive/ review boundary and outside retention — the incident bundle owns the (full-page) screenshot evidence
out_dir is the user's ordinary output directory on every run, so a shot lands there unmarked and outside retention. The PR added a docstring acknowledging the hazard; that documents it rather than gating it. Either route through the incident bundle or gate behind incident_capture.
3. The DOM snapshot bypasses the shared structural engine — and reintroduces document.title
The inline page.evaluate in _capture_ui_failure duplicates diagnostics.STRUCTURAL_DOM_JS + validate_structural_dom, so nothing re-applies the allowlist that the S12 remediation added. The snapshot writes title: String(document.title || "").slice(0, 120) — the exact field S12 stripped.
Why this is one issue
All three are the same shape: diagnostics capture that went around the machinery built to keep captured evidence inside a review boundary. Fixing them together is smaller than fixing them apart.
Activity
Merge pull request #1061 from ffroliva/bugfix/890-diagnostics-boundary
fix(diagnostics): migrated failure diagnostics stay inside the review…
chore: reconcile the ffroliva#639 branch with develop after the v0.89…