Repository navigation
fix(errors): a billed clip's failed download is not retryable (#941 part 1) - #1064
Merged
Merged
Conversation
…art 1) MediaDownloadError inherited retryable=true from NetworkError, so a scheduler re-running retryable failures would bill the clip twice. get_signed_media takes a per-call retryable; the generation downloads and the clip writer pass False, the free recovery keeps the class default. Refs #941
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 51 seconds. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…either (#941 council) client.download_image raised a plain NetworkError (retryable) after its own retries; a re-run spends daily quota again.
Owner
Author
|
Council review: YELLOW. The video paths and the constructor forwarding are correct, and the recovery path stays
Suite: 5417 passed. Part 2 (exit 7 → 6 on an HTTP error from the signed URL) stays open on #941 for the owner. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#941 part 1, decided with the evidence the issue asked for:
retryable: onlyerrors.is_retryable, surfaced in CLI--json, the MCP envelope and the worker's error record. Nothing inside gflow auto-retries, so the flag is a promise to external schedulers.docs/MCP.mddefines it as "a transient failure a scheduler can re-run without operator intervention".retryable: false.Decision: set
retryableper raise site.get_signed_mediatakesretryable: bool | None = None, passed to theMediaDownloadErrorit raises:MigratedComposer.fetch_mp4(the flow.google.com generation download) passesFalse.ui_automation_video,getMediaUrlRedirect) passesFalse._save_clip's storage failure passesFalse.migrated_recover.recover_clip(gflow data download/gflow_download_media) keeps the class defaulttrue. It spends nothing, and MCP.md documents "pause and call again".Exit code 6 and
typeare unchanged.docs/MCP.md§ Error envelope and CHANGELOG are updated.Not done: part 2. An HTTP error status on the signed URL still raises
WireFormatError(exit 7) and leaves the assetpending. Moving it toMediaDownloadErrorchanges exit 7 to 6, a separate public-contract change for the owner to decide. So this PR isRefs #941, notCloses.Refs #941
Test plan
test_it_exits_6_and_is_marked_retryablepinned the old contract. It became…_is_not_retryable_after_billingand went red, then green. A new test pins the recovery download (get_signed_mediadefault) atretryable: true./gflow:checkgates: offline suite 5416 passed.