Skip to content

fix(api): keep --password-store=basic at generation to fix macOS 401 (#222) #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ffroliva merged 1 commit into from
Jun 29, 2026
Merged

fix(api): keep --password-store=basic at generation to fix macOS 401 (#222) #225

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/gflow_cli/api/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,10 +333,16 @@ def _persistent_context_kwargs(self) -> JsonObject:
"locale": "en-US",
"extra_http_headers": {"Accept-Language": "en-US,en;q=0.9"},
"channel": channel_for_profile(self.profile_dir),
# Do NOT suppress Playwright's default --password-store=basic here.
# auth login (auth/real_chrome.py) seals the profile's cookies with
# the *basic* store; if generation lets Chrome fall back to the OS
# keychain (macOS "Chrome Safe Storage") the basic-sealed cookies
# can't be decrypted -> logged-out context -> 401 on createProject.
# Keeping the flag (via Playwright's default) makes both paths
# symmetric. See issue #222.
"ignore_default_args": [
"--enable-automation",
"--no-sandbox",
"--password-store=basic",
],
"args": ["--disable-blink-features=AutomationControlled", "--disable-dev-shm-usage"],
}
Expand Down
7 changes: 6 additions & 1 deletion tests/api/test_client_launch_kwargs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,13 @@ def test_persistent_context_kwargs_are_unchanged(tmp_path: Path) -> None:
assert kwargs["ignore_default_args"] == [
"--enable-automation",
"--no-sandbox",
"--password-store=basic",
]
# Regression for #222: generation must NOT suppress --password-store=basic.
# auth login seals the profile cookies with the *basic* store; if generation
# lets Chrome fall back to the macOS keychain, those cookies can't be
# decrypted -> logged-out -> 401 on createProject. (Unit-level proxy: the
# real failure only reproduces on a headed Chrome on macOS.)
assert "--password-store=basic" not in kwargs["ignore_default_args"]
assert kwargs["args"] == [
"--disable-blink-features=AutomationControlled",
"--disable-dev-shm-usage",
Expand Down
Loading