Skip to content

fix(756): measure the /about retry flag, and unpin a test from terminal width - #785

Merged
ffroliva merged 1 commit into
developfrom
bugfix/about-redirect-measured
Sep 11, 2026
Merged

ffroliva merged 1 commit into
developfrom
bugfix/about-redirect-measured

Conversation

@ffroliva

@ffroliva ffroliva commented Sep 11, 2026 •

Copy link
Copy Markdown
Owner

Two independent findings, both from catching a live /about occurrence while measuring something else.

1. The /about retry flag is now measured

The 2026-09-10 spike got 0/5 — the redirect had stopped reproducing — and recorded that as unmeasured rather than as transience. It then named exactly what would settle it: catch a live occurrence and re-run with --attempts 5.

denon82 was redirecting. The script was run unmodified, so its pre-registered reading still governs.

# Result Elapsed
1–5 /about, every time 31–35 s each

5 of 5, over ~3 minutes. The session was healthy throughout (cookie present, not expired, SAPISID present, 68 cookies) and the project is the account's own. So this is neither an expired session nor a project the account cannot see.

Per the inherited reading, N/N means stable: a retry is doomed, and costs a user ~35 s to learn nothing. retryable=False was a preserved default, and both the code comment and FlowAppError's docstring said so in as many words. Those two statements became false the moment this ran. Behaviour is unchanged — the flag was already right, it just was not known to be.

Still not measured, and it says so: why it happens, and whether it ever clears. Newly excluded, narrowly: not an expired session, not a missing project, not transience.

This also explains rather than merely notes why the #780 spike could not measure the covering geometry on a second account's editor — denon82 and pr389fresh2 both land here, so neither mounts a composer.

2. An auth test depended on terminal width

Found while running the suite for (1), and proven not to be my change by a control: same --basetemp, my edits stashed, still fails.

test_auth_steps.py asserts substrings of Rich's output, which hard-wraps to the terminal. A temp path landing near the wrap column split the word:

--basetemp=…/t9     ->  "profile_e\nxperiments"  ->  FAILS
--basetemp=…/t10b   ->  "profile_experiments"    ->  passes

Same code, same assertion, one character of path. A latent CI flake waiting for a runner whose tmp path is a different length.

Pinned COLUMNS at the shared CliRunner fixture rather than normalising newlines at each of the ten assertion sites — the fixture is the single chokepoint, and fixing the symptom ten times lets the eleventh one in.

Verification

  • The four path lengths that flipped it: all pass.
  • Full offline suite at the path that exposed the flake: 4234 passed, 24 skipped.
  • ruff, ruff format, pyright src 0 errors, doc links, hygiene, website mirror.

https://claude.ai/code/session_01Nr4XuvvZv3PrL3pKEzkrLc

Summary by CodeRabbit

  • Documentation

    • Documented measured stability of the /about redirect across five consecutive attempts.
    • Clarified that the redirect is treated as non-retryable based on observed behavior, while its underlying cause remains unresolved.
    • Added supporting spike findings and updated the changelog.
  • Tests

    • Stabilized authentication output checks by using a consistent terminal width, preventing formatting-dependent assertion failures.

…al width

TWO INDEPENDENT FINDINGS, both from catching a live occurrence.

1. THE /about RETRY FLAG IS NOW MEASURED.

The 2026-09-10 spike got 0/5 -- the redirect had stopped reproducing on ci-probe -- and
recorded that as unmeasured rather than as transience. It then named exactly what would
settle it: catch a live occurrence and re-run with --attempts 5.

While measuring the #780 consent bar, denon82 turned out to be redirecting. The script
was run UNMODIFIED, so its pre-registered reading still governs:

    5 of 5 landed on /about, over ~3 minutes, 31-35 s each.

The session was healthy throughout (flow_session_cookie_present, not expired, sapisid
present, 68 cookies) and the project is the account's OWN, listed by `gflow project list`
on that same profile. So this is neither an expired session nor a project the account
cannot see.

Per the inherited reading, N/N means stable: a retry is doomed for an account in this
state. `retryable=False` at raise_if_known_landing was a PRESERVED default and both the
code comment and FlowAppError's docstring said so in as many words. Those two statements
became false the moment this ran, and they are corrected here. Behaviour is unchanged --
the flag was already right; it just wasn't known to be.

Still not measured, and said so: WHY the redirect happens, and whether it ever clears.
What is newly excluded is narrow but real: not an expired session, not a missing project,
not transience.

This also explains, rather than merely notes, why the #780 spike could not measure the
covering geometry on a second account's editor: denon82 and pr389fresh2 both land here,
so neither mounts a composer at all.

2. AN AUTH TEST DEPENDED ON TERMINAL WIDTH.

Found while running the suite for (1), and proven NOT to be my change by a control: same
--basetemp, my edits stashed, still fails.

test_auth_steps.py asserts substrings of Rich's output, which hard-wraps to the terminal.
A temp path landing near the wrap column split the word:

    --basetemp=.../t9    -> "profile_e\nxperiments"  -> FAILS
    --basetemp=.../t10b  -> "profile_experiments"    -> passes

Same code, same assertion, one character of path. That is a latent CI flake waiting for a
runner whose tmp path is a different length.

Pinned COLUMNS at the shared CliRunner fixture rather than normalising newlines at each
of the ten assertion sites -- the fixture is the single chokepoint, and fixing the symptom
ten times would let the eleventh one in. Verified across the four path lengths that
flipped it, then the full suite at the path that exposed it: 4234 passed.

Refs #756

Claude-Session: https://claude.ai/code/session_01Nr4XuvvZv3PrL3pKEzkrLc
@coderabbitai

coderabbitai Bot commented Sep 11, 2026 •

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 4b5bf215-52e4-4e49-92f6-38ab0348907c

📥 Commits

Reviewing files that changed from the base of the PR and between e0ada9b and 5b09207.

📒 Files selected for processing (6)
  • CHANGELOG.md
  • docs/superpowers/spikes/2026-09-10-about-redirect-stability.md
  • docs/superpowers/spikes/2026-09-11-about-redirect-is-stable-for-an-account.md
  • src/gflow_cli/api/transports/_common.py
  • src/gflow_cli/errors.py
  • tests/features/test_auth_steps.py

Included review availability: Your plan provides up to 2 included reviews per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The changes document five consecutive /about redirect landings, update related comments, and pin the auth test terminal width to prevent Rich output wrapping. No runtime behavior changes.

Changes

Redirect evidence and test stability

Layer / File(s) Summary
Measured redirect documentation
docs/superpowers/spikes/*, src/gflow_cli/errors.py, src/gflow_cli/api/transports/_common.py, CHANGELOG.md
Spike reports and source comments record the measured 5/5 /about landings. The changelog records the documentation updates.
Auth output stability
tests/features/test_auth_steps.py
The shared CliRunner fixture uses COLUMNS=200 to prevent Rich from wrapping asserted profile paths.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other · Severity of issue fixed: Medium

Merge Risk: ⚪ Minimal · up to 5b092

The documentation reflects the measured redirect behavior, and the auth test output is stabilized without changing production CLI behavior. No merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title accurately identifies the /about retryability measurement, but it incorrectly says the test was unpinned from terminal width. The change pins COLUMNS to remove terminal-width dependence. Replace “unpin a test from terminal width” with wording that states the test is stabilized or pinned to a fixed terminal width, such as fix(756): document /about retryability and stabilize auth output test.
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 3 files. (3 skipped: 3… Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 3 files. (3 skipped: 3 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bugfix/about-redirect-measured

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ffroliva
ffroliva merged commit 7312516 into develop Sep 11, 2026
19 checks passed
@ffroliva
ffroliva deleted the bugfix/about-redirect-measured branch September 11, 2026 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant