Skip to content

chore: track mempalace.yaml, the repo's own mining config - #810

Merged
ffroliva merged 2 commits into
developfrom
chore/track-mempalace-config
Sep 14, 2026
Merged

ffroliva merged 2 commits into
developfrom
chore/track-mempalace-config

Conversation

@ffroliva

@ffroliva ffroliva commented Sep 14, 2026 •

Copy link
Copy Markdown
Owner

Summary

mempalace.yaml has been sitting untracked and un-ignored in the repo root — the exact state that one git add -A turns into an accidental commit ([[git-add-all-sweeps-scratch-files]] is in memory from a previous instance of this). Tracking it deliberately closes that; ignoring it was the other valid answer, and this PR takes the first because the file earns its place:

  • It is gflow-cli-specific — wing: gflow-cli, 11 rooms, 39 exclude patterns.
  • Its comments carry measured tuning, not preferences, and that rationale is not recoverable from anywhere else.

What it encodes

Source code and generated data are deliberately not mined, because memory should hold what the repo cannot give back:

  • Code is already here at full fidelity and greppable, and chunking it yields function bodies severed from their call sites. In this repo, .py alone was 12,797 of 19,951 drawers (64%).
  • Generated data is not knowledge — in other repos mined with the same tool, one embeddings cache produced 15,552 drawers and build logs 29,599.
  • The diary room carries no keywords on purpose: log / notes / session hijacked USAGE.md into 180 drawers.

One change from the working-tree copy

The comments named two other repositories as supporting evidence. This repository is public, and neither name appears anywhere else in it, so committing as-is would have newly disclosed them — permanently, in git history. They are now described positionally ("a second repo", "a third"). Every figure and every lesson is unchanged; revert that hunk if you want the names back.

Test plan

  • check_repo_hygiene.py — 1083 tracked files, no violations (the gate accepts a new root-level YAML)
  • Parses as valid YAML: wing: gflow-cli, 11 rooms, 39 exclude patterns
  • check_doc_links.py / check_website_docs_pii.py / check_council_memory.py / generate_website_docs --check — green
  • No secret, credential, path or account identifier in the file — read in full before staging
  • Grep confirms no residual cross-repo names
  • Step 1b (MCP↔CLI parity): N/A — config file only; no CLI leaf, option, exit code or user-facing string.
  • Iron Law: N/A — nothing under src/, no Flow surface, no runtime behaviour. This file is read by an external tool, never by gflow.

Summary by CodeRabbit

  • New Features
    • Added a project memory configuration with 11 categorized rooms for organizing knowledge.
    • Added Portuguese-language keyword support to improve memory classification.
    • Added rules to exclude source code, generated data, logs, worktrees, and build artifacts from memory mining.
    • Added an agent-authored diary room for recording project notes and maintaining ongoing project context.

It has been sitting untracked and un-ignored in the repo root, which is the
state one `git add -A` turns into an accidental commit. Tracking it deliberately
is the fix; ignoring it would have been the other valid answer, but the file is
worth keeping: it is gflow-cli-specific (wing: gflow-cli, 11 rooms) and its
comments carry measured tuning, not preferences.

What it encodes: source and generated data are deliberately NOT mined, because
memory should hold what the repo cannot give back. Code is already here at full
fidelity and greppable, and chunking it yields function bodies severed from
their call sites -- .py alone was 12,797 of 19,951 drawers here, 64%. The
`diary` room carries no keywords on purpose: `log`/`notes`/`session` hijacked
USAGE.md into 180 drawers.

Two other repos were named in those comments as supporting evidence. This
repository is public and neither name appears anywhere else in it, so they are
now described positionally instead. Every figure and every lesson is unchanged.
@coderabbitai

coderabbitai Bot commented Sep 14, 2026 •

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 422c754f-e2b9-4690-b6d3-f440229c7abf

📥 Commits

Reviewing files that changed from the base of the PR and between 832b093 and 70e7b2c.

📒 Files selected for processing (1)
  • mempalace.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
  • mempalace.yaml

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


📝 Walkthrough

Walkthrough

The PR adds mempalace.yaml for gflow-cli. It defines the memory domain, 11 memory rooms, Portuguese keywords, diary authoring rules, mining policy comments, and patterns that exclude source code and generated files.

Changes

Memory configuration

Layer / File(s) Summary
Room definitions and mining policy
mempalace.yaml
The configuration identifies the gflow-cli wing, defines 11 memory rooms, marks diary as agent-authored-only, documents mining policies, and excludes source, dependency, build, worktree, log, and test-output files from mining.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 70e7b

The configuration introduces no verified merge-blocking risk from the available repository evidence.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and concisely describes the main change: adding and tracking the repository's mempalace.yaml mining configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/track-mempalace-config

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Review found .scss/.ipynb/.lock/.log/*output*.log are outside the miner's
readable-extension set and so can never match. They are kept deliberately --
defensive against that set widening, guarding the failure the comment above
already measures (build logs alone were 29,599 drawers elsewhere). Recorded in
the file so the next reviewer does not re-derive it, which is the same cost
ogads-pa has now imposed three times.
@ffroliva
ffroliva merged commit 7a44dff into develop Sep 14, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant