fix(firestore-send-email): improve attachments validation error message#2583
Closed
HassanBahati wants to merge 9 commits into
Closed
fix(firestore-send-email): improve attachments validation error message#2583HassanBahati wants to merge 9 commits into
HassanBahati wants to merge 9 commits into
Conversation
…onStart event (#2562) * fix(storage-resize-images): add missing recordStartEvent call * feat(storage-resize-images): add onStorageResize event * docs(storage-resize-images): update changelog * chore(storage-resize-images): add onStartResize * chore(storage-resize-images): add onStartResize event --------- Co-authored-by: Tadej <tadej.dev@gmail.com>
cabljac
reviewed
Jan 12, 2026
cabljac
reviewed
Jan 12, 2026
| if (issue.message && !issue.message.startsWith("Expected")) { | ||
| return issue.message; | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Actually i think a cleaner fix is I think in here we need
case "invalid_type":
// Missing required field (received undefined)
if (issue.received === "undefined") {
return `Field '${path}' must be a ${issue.expected}`;
}
// Type mismatch cases
if (issue.expected === "string") {
return `Field '${path}' must be a string`;
}
if (issue.expected === "array") {
return `Field '${path}' must be an array`;
}
Contributor
There was a problem hiding this comment.
@HassanBahati did you push changes taking this approach? i dont see them
Contributor
|
closing this as superseded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2550 (comment)
Adds a custom error message to attachmentsSchema when an object is provided instead of an array. The new message guides users to wrap single attachment objects in an array format.