Defined reCAPTCHA config. - #1574
Merged
Merged
Conversation
- Added reCAPTCHA protection states. - Added reCAPTCHA action rule. - Added reCAPTCHA key config. No tests needed for this change.
renkelvin
reviewed
Feb 11, 2022
renkelvin
left a comment
renkelvin
left a comment
There was a problem hiding this comment.
It seems better to move the configs to auth-config.ts as other configs there.
Added reCAPTCHA protection states. Added reCAPTCHA action rule. Added reCAPTCHA key config.
Xiaoshouzi-gh
marked this pull request as ready for review
February 14, 2022 17:52
Member
|
Thanks, @Xiaoshouzi-gh ! Is the plan to update tenant and project config interfaces in a separate PR? |
| } | ||
|
|
||
| /** | ||
| * The key's platform type: only web supported now.. |
Contributor
Author
There was a problem hiding this comment.
- Fixed extra
.. - As of the TW review, we were planning to have a TW to do a full review when all pieces in the reCaptcha is ready to be merge into the master branch.
- Yes, the plan is the update the tenant and project config in a separate PR.
lahirumaramba
approved these changes
Feb 14, 2022
Xiaoshouzi-gh
added a commit
that referenced
this pull request
Mar 2, 2023
* Defined reCAPTCHA config. - Added reCAPTCHA protection states. - Added reCAPTCHA action rule. - Added reCAPTCHA key config.
Xiaoshouzi-gh
added a commit
that referenced
this pull request
Mar 30, 2023
* Defined reCAPTCHA config. - Added reCAPTCHA protection states. - Added reCAPTCHA action rule. - Added reCAPTCHA key config.
Xiaoshouzi-gh
added a commit
that referenced
this pull request
Apr 11, 2023
* Defined reCAPTCHA config. - Added reCAPTCHA protection states. - Added reCAPTCHA action rule. - Added reCAPTCHA key config.
Xiaoshouzi-gh
added a commit
that referenced
this pull request
Apr 12, 2023
* Defined reCAPTCHA config. - Added reCAPTCHA protection states. - Added reCAPTCHA action rule. - Added reCAPTCHA key config.
Xiaoshouzi-gh
added a commit
that referenced
this pull request
Apr 12, 2023
reCAPTCHA support * Defined reCAPTCHA config. (#1574) - Added reCAPTCHA protection states. - Added reCAPTCHA action rule. - Added reCAPTCHA key config. * Create/Update tenant with ReCAPTCHA Config (#1586) * Support reCaptcha config /create update on tenants. - Support create and update tenants with reCaptcha config. - Added reCaptcha unit tests on tenants operations. * Project config - Recaptcha config (#1595) * Recaptcha config changes in project config. - Implemented getProjectConfig. - Implemented updateProjectConfig. - Updated error code. - Add Term of Service consents. * Recapcha integ test (#1599) * Added integ test for Project Config and Tenants update on reCAPTCHA config * Account defender support for reCAPTCHA (#1616) * Support use_account_defender add-on feature for reCAPTCHA config. * Added integration test for account defender feature.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No tests needed for this change.
Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:
Discussion
If not, go file an issue about this before creating a pull request to discuss.
Testing
API Changes
us make Firebase APIs better, please propose your change in an issue so that we
can discuss it together.