feat: remove custom tags feature and standardize release tags - #1954
Conversation
### Description Removes the custom `--dist-tag` option from the publish script and pipeline. Prereleases are now tagged with `next`, and stable releases are tagged with both `latest` and `next`. ### Release notes relnote: none
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request simplifies the publishing process by removing the --dist-tag option from both the publish.sh script and the Cloud Build configuration. The script now directly determines the NPM distribution tag (next or latest) based on whether it is a prerelease. Additionally, error handling for unknown CLI arguments has been introduced. The feedback suggests redirecting the new error message to standard error (stderr) instead of standard output (stdout) to align with CLI best practices.
| echo "🔍 [Dry Run] Skipping npm publish --tag next" | ||
| else | ||
| echo "🔍 [Dry Run] Skipping npm publish --tag latest" | ||
| echo "🔍 [Dry Run] Skipping npm dist-tag add ${PACKAGE_NAME}@${NEXT_VERSION} next" |
There was a problem hiding this comment.
Do you still need this log referring to dist-tag? Not sure if related.
There was a problem hiding this comment.
I'ts part of what would happen so it makes sense to keep it in the dry run.
4 participants
Description
Removes the custom
--dist-tagoption from the publish script and Cloud Build config. Prereleases are now tagged withnext, and full releases are tagged with bothlatestandnext.Release notes
relnote: none