Skip to content

refactor(ai): refine LiveServerVoiceActivity public API - #17007

Merged
ncooke3 merged 2 commits into
mainfrom
nc.ai.voice-activity
Nov 5, 2026
Merged

ncooke3 merged 2 commits into
mainfrom
nc.ai.voice-activity

Conversation

@ncooke3

@ncooke3 ncooke3 commented Nov 4, 2026

Copy link
Copy Markdown
Member

Apply API review follow-up feedback to the Public Preview Live API voice activity types:

  • Make VoiceActivityType.unknown internal instead of exposing it publicly, matching other DecodableProtoEnum types in FirebaseAI.
  • Rename VoiceActivityType.activityStart and activityEnd to start and end per Swift API Design Guidelines to omit needless words.
  • Make LiveServerVoiceActivity.audioOffset a non-optional TimeInterval defaulting to 0 instead of TimeInterval?, since the Agent Platform backend omits 0 durations on the wire.

Apply API review follow-up feedback to the Public Preview Live API voice activity types:
- Make VoiceActivityType.unknown internal instead of exposing it publicly, matching other DecodableProtoEnum types in FirebaseAI.
- Rename VoiceActivityType.activityStart and activityEnd to start and end per Swift API Design Guidelines to omit needless words.
- Make LiveServerVoiceActivity.audioOffset a non-optional TimeInterval defaulting to 0 instead of TimeInterval?, since the Agent Platform backend omits 0 durations on the wire.
@gemini-code-assist

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@ncooke3
ncooke3 requested review from andrewheard and paulb777 and removed request for paulb777 November 4, 2026 22:00
@andrewheard
andrewheard marked this pull request as ready for review November 4, 2026 23:02
Co-authored-by: Andrew Heard <andrewheard@google.com>
@ncooke3
ncooke3 merged commit 0e7323b into main Nov 5, 2026
63 checks passed
@ncooke3
ncooke3 deleted the nc.ai.voice-activity branch November 5, 2026 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants