Skip to content

Crashlytics iOS Documentation Issue [Legacy/New Build System, Last Build Script] #1090

Open

Description

@stolyarenkokswing

Problem Description:

Crashlytics documentation has a note in step 3 about fact that we need to be sure that the new run script will be run as the last build script.

Step 3: Initialize Crashlytics
Note: Make sure your new build phase is the project's last build phase or Crashlytics can't initialize properly.
https://firebase.google.com/docs/crashlytics/get-started

We can guarantee this only with the Legacy Build System, but on New Build System this phase may not necessarily be the last one.
https://medium.com/xcblog/five-things-you-must-know-about-xcode-10-new-build-system-41676cd5fd6c

Conclusion:

If you have already updated the code and it works correctly on the New Build System, please let us know and update the documentation.

If the code does not work correctly on a New Build System, please indicate in the documentation that only the Legacy Build System should be used, since only in it we can guarantee that the script will be executed last.

Activity

  1. changed the title [-]iOS Crashlytics Documentation Issue [Legacy/New Build System][/-] [+]Crashlytics iOS Documentation Issue [Legacy/New Build System][/+] on Nov 25, 2020
  2. changed the title [-]Crashlytics iOS Documentation Issue [Legacy/New Build System][/-] [+]Crashlytics iOS Documentation Issue [Legacy/New Build System, Last Build Script][/+] on Nov 25, 2020
  3. morganchen12 commented on Nov 30, 2020

    @morganchen12
    Contributor

    Thanks for the heads up. The Crashlytics scripts should work correctly with the new build system, though the docs may need to be updated.

  4. stolyarenkokswing commented on Nov 30, 2020

    @stolyarenkokswing
    Author

    Ok, thanks for the quick response!
    Then, as I understand correctly, if we provide input files and execute the necessary scripts on a new build system without taking into account the note in the documentation that the scripts must be executed last - everything will work correctly?

  5. morganchen12 commented on Nov 30, 2020

    @morganchen12
    Contributor

    They really only need to be executed after the binary compilation is finished and the dSYMs have been generated, according to my knowledge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions