You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
GitOps policy install_software errors say "team" instead of "fleet" #55077
Follow-up to #54778, which reworded the "can only be set on team policies" errors. These are the remaining install_software errors on a fleet's policies that still say "team". All five are in pkg/spec/gitops.go (parsePolicyInstallSoftware):
install_software.package_path URL <url> not found on team: <path>
install_software.package_path SHA256 <sha> not found on team: <path>
install_software.hash_sha256 <sha> not found on team
install_software.app_store_id <id> not found on team <fleet name>
install_software.fleet_maintained_app_slug "<slug>" not found in software.fleet_maintained_apps for team <fleet name>
Change
TODO
Test plan
These checks run in fleetctl while it parses the YAML, so --dry-run is enough.
In a fleet file (fleets/<name>.yml) with an empty software: section, add these policies:
I’d like to take this quick win if it’s still available.
I’ve confirmed the five install_software errors are in pkg/spec/gitops.go. I can update the wording, add or adjust focused tests for those errors, and verify the expected output with fleetctl gitops --dry-run as described in the issue. Please let me know if this scope works.
Thanks @marko-lisica! I'm on it. I'll update all five install_software errors in pkg/spec/gitops.go to say "fleet", and add test coverage for the three messages that don't have any yet (package SHA256, app_store_id, Fleet-maintained app slug). I'll also check the output with fleetctl gitops --dry-run using the test plan, then open the PR shortly.
QA Pass — 7/7 checks on rc-minor-fleet-v4.95.0 (cherry-pick #57388). fleetctl gitops --dry-run with the test plan's five policies, run with 4.95 RC fleetctl and with 4.94 RC fleetctl for comparison.
#
Type
Case
Result
1
Core
package_path to a package YAML with a url that isn't in the fleet
✅ …URL https://example.com/a.pkg not found on fleet: ./software/url.yml
2
Core
package_path to a package YAML with a hash_sha256 that isn't in the fleet
✅ …package_path SHA256 <sha> not found on fleet: ./software/sha.yml
3
Core
bare hash_sha256 that isn't in the fleet
✅ …hash_sha256 <sha> not found on fleet
4
Core
app_store_id that isn't in the fleet
✅ …app_store_id 123 not found on fleet qa-55077
5
Core
fleet_maintained_app_slug that isn't in the fleet
✅ …"1password/darwin" not found in software.fleet_maintained_apps for fleet qa-55077
6
Regression
Same file, 4.94 RC fleetctl
✅ old "team" wording shows up, so the change is only in 4.95
7
Regression
Same policies with the software listed in the fleet
Activity
Prajwal2246 commentedon Oct 12, 2026
I’d like to take this quick win if it’s still available.
I’ve confirmed the five
install_softwareerrors are inpkg/spec/gitops.go. I can update the wording, add or adjust focused tests for those errors, and verify the expected output withfleetctl gitops --dry-runas described in the issue. Please let me know if this scope works.marko-lisica commentedon Oct 23, 2026
Hey @Prajwal2246, I just saw your comment. Feel free to take this one.
Prajwal2246 commentedon Oct 23, 2026
Thanks @marko-lisica! I'm on it. I'll update all five
install_softwareerrors inpkg/spec/gitops.goto say "fleet", and add test coverage for the three messages that don't have any yet (package SHA256,app_store_id, Fleet-maintained app slug). I'll also check the output withfleetctl gitops --dry-runusing the test plan, then open the PR shortly.Use "fleet" instead of "team" in GitOps install_software errors (#56423)
Brajim20 commentedon Nov 4, 2026
QA Pass — 7/7 checks on
rc-minor-fleet-v4.95.0(cherry-pick #57388).fleetctl gitops --dry-runwith the test plan's five policies, run with 4.95 RC fleetctl and with 4.94 RC fleetctl for comparison.package_pathto a package YAML with aurlthat isn't in the fleet…URL https://example.com/a.pkg not found on fleet: ./software/url.ymlpackage_pathto a package YAML with ahash_sha256that isn't in the fleet…package_path SHA256 <sha> not found on fleet: ./software/sha.ymlhash_sha256that isn't in the fleet…hash_sha256 <sha> not found on fleetapp_store_idthat isn't in the fleet…app_store_id 123 not found on fleet qa-55077fleet_maintained_app_slugthat isn't in the fleet…"1password/darwin" not found in software.fleet_maintained_apps for fleet qa-55077Brajim20 commentedon Nov 4, 2026
@Prajwal2246
these ones were left behind
#57505