Skip to content

GitOps policy install_software errors say "team" instead of "fleet" #55077

Open

Description

@Brajim20

Goal

User story
As an IT admin setting up policy automations via GitOps,
I want to see error messages that say "fleet" instead of "team"
so that I can understand the error using the same terminology as the rest of Fleet.

For help creating a user story, see "Writing a good user story" in the website handbook.

Follow-up to #54778, which reworded the "can only be set on team policies" errors. These are the remaining install_software errors on a fleet's policies that still say "team". All five are in pkg/spec/gitops.go (parsePolicyInstallSoftware):

  • install_software.package_path URL <url> not found on team: <path>
  • install_software.package_path SHA256 <sha> not found on team: <path>
  • install_software.hash_sha256 <sha> not found on team
  • install_software.app_store_id <id> not found on team <fleet name>
  • install_software.fleet_maintained_app_slug "<slug>" not found in software.fleet_maintained_apps for team <fleet name>

Change

  • TODO

Test plan

These checks run in fleetctl while it parses the YAML, so --dry-run is enough.

In a fleet file (fleets/<name>.yml) with an empty software: section, add these policies:

policies:
  - name: QA url
    query: SELECT 1;
    install_software:
      package_path: ./software/url.yml        # contains: url: https://example.com/a.pkg
  - name: QA sha
    query: SELECT 1;
    install_software:
      package_path: ./software/sha.yml        # contains: hash_sha256: "<any 64 hex chars>"
  - name: QA hash
    query: SELECT 1;
    install_software:
      hash_sha256: "<any 64 hex chars>"
  - name: QA app store
    query: SELECT 1;
    platform: darwin
    install_software:
      app_store_id: "123"
  - name: QA fma
    query: SELECT 1;
    install_software:
      fleet_maintained_app_slug: 1password/darwin

Run fleetctl gitops -f fleets/<name>.yml --dry-run.

Expected: all five errors say "fleet" instead of "team", and none of them says "team" anywhere.

Activity

  1. Prajwal2246 commented on Oct 12, 2026

    @Prajwal2246
    Contributor

    I’d like to take this quick win if it’s still available.

    I’ve confirmed the five install_software errors are in pkg/spec/gitops.go. I can update the wording, add or adjust focused tests for those errors, and verify the expected output with fleetctl gitops --dry-run as described in the issue. Please let me know if this scope works.

  2. moved this from 📨 Inbox to 🦢 Drafting in ❤️‍🩹 #g-auto-patchingon Oct 23, 2026
  3. self-assigned this
    on Oct 23, 2026
  4. marko-lisica commented on Oct 23, 2026

    @marko-lisica
    Member

    Hey @Prajwal2246, I just saw your comment. Feel free to take this one.

  5. Prajwal2246 commented on Oct 23, 2026

    @Prajwal2246
    Contributor

    Thanks @marko-lisica! I'm on it. I'll update all five install_software errors in pkg/spec/gitops.go to say "fleet", and add test coverage for the three messages that don't have any yet (package SHA256, app_store_id, Fleet-maintained app slug). I'll also check the output with fleetctl gitops --dry-run using the test plan, then open the PR shortly.

  6. added this to the 4.95.0 milestone on Oct 23, 2026
  7. moved this from 🦢 Drafting to 🐥 Ready for review in ❤️‍🩹 #g-auto-patchingon Oct 26, 2026
  8. added a commit that references this issue on Nov 3, 2026
    eec44aa
  9. moved this from 🐥 Ready for review to ✔️Awaiting QA in ❤️‍🩹 #g-auto-patchingon Nov 3, 2026
  10. Brajim20 commented on Nov 4, 2026

    @Brajim20
    MemberAuthor

    QA Pass — 7/7 checks on rc-minor-fleet-v4.95.0 (cherry-pick #57388). fleetctl gitops --dry-run with the test plan's five policies, run with 4.95 RC fleetctl and with 4.94 RC fleetctl for comparison.

    # Type Case Result
    1 Core package_path to a package YAML with a url that isn't in the fleet ✅ …URL https://example.com/a.pkg not found on fleet: ./software/url.yml
    2 Core package_path to a package YAML with a hash_sha256 that isn't in the fleet ✅ …package_path SHA256 <sha> not found on fleet: ./software/sha.yml
    3 Core bare hash_sha256 that isn't in the fleet ✅ …hash_sha256 <sha> not found on fleet
    4 Core app_store_id that isn't in the fleet ✅ …app_store_id 123 not found on fleet qa-55077
    5 Core fleet_maintained_app_slug that isn't in the fleet ✅ …"1password/darwin" not found in software.fleet_maintained_apps for fleet qa-55077
    6 Regression Same file, 4.94 RC fleetctl ✅ old "team" wording shows up, so the change is only in 4.95
    7 Regression Same policies with the software listed in the fleet ✅ dry run succeeds, no install_software errors
  11. Brajim20 commented on Nov 4, 2026

    @Brajim20
    MemberAuthor

    @Prajwal2246

    these ones were left behind
    #57505

  12. moved this from ✔️Awaiting QA to ✅ Ready for release in ❤️‍🩹 #g-auto-patchingon Nov 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions