Repository navigation
Description
Fleet versions
- Discovered:
main(702fa07637), with the CPE database from nvd release202610290055 - Reproduced:
main(58124479ac), with nvd releases202610290055through202610310124
Web browser and operating system: N/A (vulnerability processing)
💥 Actual behavior
The Python package Brotli 1.0.9 (python_packages) is matched to the CPE for the Go port of brotli. The brotli Homebrew formula (homebrew_packages) has the same problem:
cpe:2.3:a:andybalholm:brotli:1.0.9:*:*:*:*:python:*:*
On 2026-10-29, NVD added andybalholm:brotli CPEs with target_sw=go and re-issued the google:brotli CPEs with target_sw=-. In CPEFromSoftware, both vendors pass cpeItemMatchesSoftware, and both score 0 in cpeTargetSWMatchesSoftware, because neither go nor - matches python. The software has no vendor, so the vendor tie-breaker doesn't apply either. With a full tie, the first candidate wins. Candidates are ordered by vendor, so andybalholm comes before google.
As a result, Python and Homebrew brotli get the Go port's CPE. Fleet generates the CPE with the software's own target_sw (python or macos), so it matches neither the Go port's CVEs (target_sw=go) nor Google's. Google brotli vulnerabilities are missed, for example CVE-2020-8927 on versions before 1.0.8.
TestCPEFromSoftwareIntegration has failed in the nightly vuln job on every run since 2026-10-29:
expected: "cpe:2.3:a:google:brotli:1.0.9:*:*:*:*:python:*:*"
actual : "cpe:2.3:a:andybalholm:brotli:1.0.9:*:*:*:*:python:*:*"
No code under server/vulnerabilities/ changed between the last passing run (2026-10-28, d4a0f4c044) and the first failing run. Running the test locally passes with the nvd release 202610280126 CPE database and fails with 202610290055 and later.
🛠️ Expected behavior
Brotli from python_packages and brotli from homebrew_packages map to google:brotli, for example cpe:2.3:a:google:brotli:1.0.9:*:*:*:*:python:*:*.
🧑💻 Steps to reproduce
These steps:
- Have been confirmed to consistently lead to reproduction in multiple Fleet instances.
- Describe the workflow that led to the error, but have not yet been reproduced in multiple Fleet instances.
- Download and decompress
cpe-*.sqlite.gzfrom nvd release202610290055or later. - Run
NVD_TEST_CPEDB_PATH=<path to cpe.sqlite> go test -tags fts5 -run 'TestCPEFromSoftwareIntegration$' ./server/vulnerabilities/nvd/. - The test fails on the
Brotlicase with the output shown above.
🕯️ More info (optional)
- Nightly failing run: https://github.com/fleetdm/fleet/actions/runs/41166762873/job/124435895875
Metadata
Metadata
Assignees
Labels
Type
Projects
- StatusShow more project fields✅ Ready for release
Activity
[-]Python packages can match CPEs scoped to a different ecosystem (e.g. Brotli → andybalholm:brotli)[/-][+]Python and Homebrew brotli matched to the Go port's CPE (andybalholm:brotli), missing Google brotli CVEs[/+]Map Python and Homebrew brotli to Google's CPE
marcusallen97 commentedon Nov 6, 2026
The test case mentioned above passed.
@juan-fdz-hawa - One gap this rule doesn't close, and I think it needs its own issue. CVE-2026-111497 (Google brotli decoder overflow, 1.0.3–1.0.9 / 1.1.0 / 1.2.0) is listed in NVD only as cpe:2.3:a:google:brotli::::::-::. Fleet generates target_sw=python / macos, which doesn't match -, so nvdvuln reports no CVE for Python Brotli 1.0.9 or Homebrew brotli 1.2.0 even though both are in range. CVE-2020-8927 only matched because its config uses target_sw=. That's the target_sw=- re-issue you called out in the description, so the vendor pin fixes the tie-break but not the match. Happy to file it if you agree.
marcusallen97 commentedon Nov 6, 2026
QA Summary
Validated PR #57209 (issue #57201) on the 4.95 RC branch (
e58b706d49, server4.95.0-rc.2611051703) against nvd release202611060046. Ran the issue's repro test plus a pre-fix negative control, thenvdvulnharness on the affected and neighbouring packages, and an end-to-end pass on a macOS host (brew install brotli1.2.1,pip install Brotli==1.0.7) through refetch, the vulnerabilities cron, the DB and the software versions API. The fix works as written; one out-of-scope gap was found (NVD configs withtarget_sw=-still don't match Fleet'spython/macosCPEs) and is being reported separately.juan-fdz-hawa commentedon Nov 10, 2026
Thanks - let's file a new issue for this.
marcusallen97 commentedon Nov 10, 2026
Thanks @juan-fdz-hawa — filed as #58295