Skip to content

filtering out dtgen related files in code coverage report - #1406

Merged
lockshaw merged 13 commits into
flexflow:repo-refactorfrom
Bob-Chen222:test-codecov
Jun 4, 2024
Merged

filtering out dtgen related files in code coverage report #1406
lockshaw merged 13 commits into
flexflow:repo-refactorfrom
Bob-Chen222:test-codecov

Conversation

@Bob-Chen222

@Bob-Chen222 Bob-Chen222 commented Jun 4, 2024

Copy link
Copy Markdown
Contributor

Description of changes:

filtering out dtgen related files in code coverage report in ci. Previously the problem is that gcov in codecov/action will be run again as plugin and all the .gcov files will be generated and included into the final report. I disabled gcov by specify the pycoverage to be used as plugin, which temporarily solved the problem. Since we are going to move ci to proj I think this solution is good enough for now. I will investigate further in the background

Related Issues:

Linked Issues:

  • Issue #

Issues closed by this PR:

  • Closes #

This change is Reviewable

@Bob-Chen222 Bob-Chen222 self-assigned this Jun 4, 2024
@Bob-Chen222
Bob-Chen222 marked this pull request as draft June 4, 2024 03:56
@codecov

codecov Bot commented Jun 4, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.10%. Comparing base (f93e262) to head (4103cc8).

Current head 4103cc8 differs from pull request most recent head ec02c14

Please upload reports for the commit ec02c14 to get more accurate results.

Additional details and impacted files
@@                Coverage Diff                 @@
##           repo-refactor    #1406       +/-   ##
==================================================
+ Coverage          18.81%   38.10%   +19.28%     
==================================================
  Files                263      167       -96     
  Lines              12631     5026     -7605     
  Branches               0      246      +246     
==================================================
- Hits                2377     1915      -462     
+ Misses             10254     3111     -7143     
Flag Coverage Δ
unittests 38.10% <ø> (+19.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 116 files with indirect coverage changes

@Bob-Chen222 Bob-Chen222 changed the title testing for codecov filtering out dtgen related files in code coverage report Jun 4, 2024
@Bob-Chen222
Bob-Chen222 marked this pull request as ready for review June 4, 2024 15:23
@Bob-Chen222
Bob-Chen222 requested a review from lockshaw June 4, 2024 15:23
lockshaw
lockshaw previously approved these changes Jun 4, 2024

@lockshaw lockshaw left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the solution not just https://docs.codecov.com/docs/ignoring-paths?

Reviewed 1 of 1 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Bob-Chen222)

@Bob-Chen222
Bob-Chen222 requested a review from lockshaw June 4, 2024 19:40

@Bob-Chen222 Bob-Chen222 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @lockshaw)

@lockshaw lockshaw left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Bob-Chen222)


codecov.yml line 7 at r3 (raw file):

ignore:
  # - "/home/runner/work/FlexFlow/FlexFlow/deps"

Remove comment?

@lockshaw lockshaw left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Bob-Chen222)

@lockshaw
lockshaw enabled auto-merge (squash) June 4, 2024 23:40
@lockshaw
lockshaw merged commit 89cbe93 into flexflow:repo-refactor Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants