filtering out dtgen related files in code coverage report - #1406
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## repo-refactor #1406 +/- ##
==================================================
+ Coverage 18.81% 38.10% +19.28%
==================================================
Files 263 167 -96
Lines 12631 5026 -7605
Branches 0 246 +246
==================================================
- Hits 2377 1915 -462
+ Misses 10254 3111 -7143
Flags with carried forward coverage won't be shown. Click here to find out more. |
lockshaw
left a comment
There was a problem hiding this comment.
Why is the solution not just https://docs.codecov.com/docs/ignoring-paths?
Reviewed 1 of 1 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Bob-Chen222)
Bob-Chen222
left a comment
There was a problem hiding this comment.
done.
Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @lockshaw)
lockshaw
left a comment
There was a problem hiding this comment.
Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Bob-Chen222)
codecov.yml line 7 at r3 (raw file):
ignore: # - "/home/runner/work/FlexFlow/FlexFlow/deps"
Remove comment?
lockshaw
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Bob-Chen222)
Description of changes:
filtering out dtgen related files in code coverage report in ci. Previously the problem is that gcov in codecov/action will be run again as plugin and all the .gcov files will be generated and included into the final report. I disabled gcov by specify the pycoverage to be used as plugin, which temporarily solved the problem. Since we are going to move ci to proj I think this solution is good enough for now. I will investigate further in the background
Related Issues:
Linked Issues:
Issues closed by this PR:
This change is