Skip to content

Run proj dtgen in CI - #1424

Merged
lockshaw merged 2 commits into
flexflow:repo-refactorfrom
lockshaw:proj-dtgen-in-ci
Jun 26, 2024
Merged

Run proj dtgen in CI#1424
lockshaw merged 2 commits into
flexflow:repo-refactorfrom
lockshaw:proj-dtgen-in-ci

Conversation

@lockshaw

@lockshaw lockshaw commented Jun 26, 2024

Copy link
Copy Markdown
Collaborator

Description of changes:

Run proj dtgen in CI so that .dtg.h and .dtg.cc files don't need to be committed into the repo

Related Issues:

Linked Issues:

  • Issue #

Issues closed by this PR:

  • Closes #

This change is Reviewable

@codecov

codecov Bot commented Jun 26, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.28%. Comparing base (d456733) to head (f17a59b).

Additional details and impacted files
@@              Coverage Diff               @@
##           repo-refactor    #1424   +/-   ##
==============================================
  Coverage          39.28%   39.28%           
==============================================
  Files                253      253           
  Lines               8859     8859           
  Branches             324      324           
==============================================
  Hits                3480     3480           
  Misses              5379     5379           
Flag Coverage Δ
unittests 39.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@lockshaw
lockshaw marked this pull request as ready for review June 26, 2024 03:55
@lockshaw
lockshaw enabled auto-merge (squash) June 26, 2024 04:02

@reyna-abhyankar reyna-abhyankar left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 282 of 282 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Bob-Chen222 and @lockshaw)


flake.nix line 104 at r1 (raw file):

              lcov # for code coverage
            ])
            (with proj-repo.packages.${system}; [

What does moving this here do?


.github/workflows/per-lib-check.yml line 57 at r1 (raw file):

      - name: Regenerate all dtgen files
        run: |
          proj dtgen --force --delete-outdated

So when pulling in changes, we should run this command?

@lockshaw lockshaw left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Bob-Chen222 and @reyna-abhyankar)


flake.nix line 104 at r1 (raw file):

Previously, reyna-abhyankar (Reyna Abhyankar) wrote…

What does moving this here do?

Makes proj available in CI (shouldn't develop experience at all, as the default shell inherits dependencies from the ci shell)


.github/workflows/per-lib-check.yml line 57 at r1 (raw file):

Previously, reyna-abhyankar (Reyna Abhyankar) wrote…

So when pulling in changes, we should run this command?

No, it (minus the force parameter) gets auto-run by proj build, proj test, etc. (I think also proj cmake). You shouldn't have to do anything differently on your side, this only affects CI

@reyna-abhyankar reyna-abhyankar left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Bob-Chen222)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants