Updated nonnegative_int tests to use _n literals #1658
Open
khoang05 wants to merge 2 commits into
Open
Conversation
…nsertions(+), 60 deletions(-) khoang21@sapling2:~/ff$ git push -u origin use-nonnegative-int-literals# Please enter the commit message for your changes. Lines starting Username for 'https://github.com': khoang05# with '#' will be ignored, and an empty message aborts the commit. Password for 'https://khoang05@github.com': # remote: Invalid username or token. Password authentication is not supported for Git operations.# On branch use-nonnegative-int-literals fatal: Authentication failed for 'https://github.com/flexflow/flexflow-train.git/'# Changes to be committed: khoang21@sapling2:~/ff$ git remote -v# modified: lib/utils/test/src/utils/nonnegative_int/nonnegative_int.cc origin https://github.com/flexflow/flexflow-train.git (fetch)# origin https://github.com/flexflow/flexflow-train.git (push) khoang21@sapling2:~/ff$ git remote set-url origin https://github.com/khoang05/flexflow-train.git khoang21@sapling2:~/ff$ git push -u origin use-nonnegative-int-literals Username for 'https://github.com': khoang05 Password for 'https://khoang05@github.com':
Co-authored-by: Elliott Slaughter <elliottslaughter@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…nsertions(+), 60
deletions(-)
khoang21@sapling2:
/ff$ git push -u origin use-nonnegative-int-literals# Please enter the commit message for your changes. Lines starting Username for 'https://github.com': khoang05# with '#' will be ignored, and an empty message aborts the commit. Password for 'https://khoang05@github.com': # remote: Invalid username or token. Password authentication is not supported for Git operations.# On branch use-nonnegative-int-literals fatal: Authentication failed for 'https://github.com/flexflow/flexflow-train.git/'# Changes to be committed: khoang21@sapling2:/ff$ git remote -v# modified: lib/utils/test/src/utils/nonnegative_int/nonnegative_int.cc origin https://github.com/flexflow/flexflow-train.git (fetch)# origin https://github.com/flexflow/flexflow-train.git (push) khoang21@sapling2:/ff$ git remote set-url origin https://github.com/khoang05/flexflow-train.git khoang21@sapling2:/ff$ git push -u origin use-nonnegative-int-literals Username for 'https://github.com': khoang05 Password for 'https://khoang05@github.com':Description of changes:
Related Issues:
Linked Issues:
Issues closed by this PR:
This change is