Skip to content

fix: move email actions to daemon - #1378

Merged
andrinoff merged 5 commits into
floatpane:masterfrom
mavonx:fix/issue-1255
May 31, 2026
Merged

fix: move email actions to daemon#1378
andrinoff merged 5 commits into
floatpane:masterfrom
mavonx:fix/issue-1255

Conversation

@mavonx

@mavonx mavonx commented May 30, 2026

Copy link
Copy Markdown
Member

What?

Delegates email operations (delete, archive, move) to the daemon instead of blocking the UI with loading spinners.

Why?

Email operations can take time, especially for batch actions or slower IMAP connections. By delegating them to the daemon, the UI remains responsive, operations continue in the background, and users can safely close the TUI without interrupting the work.

Closes #1255

@mavonx
mavonx requested a review from a team as a code owner May 30, 2026 11:20

@floatpanebot floatpanebot left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mavonx! Please fix the following issues with your PR:

  • Title: Is too long (40 characters). The PR title must be strictly under 40 characters.

@floatpanebot floatpanebot added bug Something isn't working size/L Diff: 201–800 lines labels May 30, 2026
@mavonx mavonx changed the title fix: delegate email operations to daemon fix: move email actions to daemon May 30, 2026
@floatpanebot
floatpanebot dismissed their stale review May 30, 2026 11:21

Formatting issues have been resolved. Thank you!

@mavonx
mavonx requested review from a team, FromSi and andrinoff May 30, 2026 11:22
@mavonx
mavonx marked this pull request as draft May 30, 2026 11:51
@mavonx
mavonx marked this pull request as ready for review May 30, 2026 11:58
@mavonx
mavonx marked this pull request as draft May 30, 2026 12:04
@mavonx
mavonx marked this pull request as ready for review May 30, 2026 12:35
@floatpanebot floatpanebot added the area/daemon Daemon / RPC label May 30, 2026
@mavonx

mavonx commented May 30, 2026

Copy link
Copy Markdown
Member Author

@andrinoff I pulled the updates and re-tested, but the delay is still there.

@andrinoff

Copy link
Copy Markdown
Member

@mavonx your previous daemon is likely running, go run . daemon stop and open the inbox

@mavonx

mavonx commented May 31, 2026

Copy link
Copy Markdown
Member Author

@andrinoff

That's correct, I forgot to restart the daemon. Could you review the code before we merge?

Comment thread main.go
Comment thread main.go
Comment thread main.go
@andrinoff

Copy link
Copy Markdown
Member

also i'd follow up with #1139, because, now 1 click means, that the message is deleted for sure.

@mavonx

mavonx commented May 31, 2026

Copy link
Copy Markdown
Member Author

@andrinoff Could you review it again now? I'll take care of #1139 in a separate PR.

@andrinoff
andrinoff enabled auto-merge (squash) May 31, 2026 12:53
@andrinoff
andrinoff merged commit 54017d8 into floatpane:master May 31, 2026
27 checks passed
@floatpane floatpane deleted a comment from mavonx May 31, 2026
@floatpane floatpane deleted a comment from andrinoff May 31, 2026
@floatpane floatpane deleted a comment from andrinoff May 31, 2026
@floatpane floatpane deleted a comment from andrinoff May 31, 2026
@mavonx
mavonx deleted the fix/issue-1255 branch May 31, 2026 13:00
andrinoff added a commit to andrinoff/matcha that referenced this pull request Jun 15, 2026
## What?

Adds a grace period for actions (move, delete)

## Why?

Follow-up on floatpane#1378

---------

Signed-off-by: drew <me@andrinoff.com>
andrinoff added a commit that referenced this pull request Jun 15, 2026
Adds a grace period for actions (move, delete)

Follow-up on #1378

---------

Signed-off-by: drew <me@andrinoff.com>
(cherry picked from commit 1ae21f4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/daemon Daemon / RPC bug Something isn't working size/L Diff: 201–800 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FEAT: Background Archiving/Deleting/Moving

3 participants