Skip to content

fix(ui): use overlay for move modal - #1440

Merged
steveevansdev merged 1 commit into
floatpane:masterfrom
andrinoff:fix/move-modal
Jun 4, 2026
Merged

fix(ui): use overlay for move modal#1440
steveevansdev merged 1 commit into
floatpane:masterfrom
andrinoff:fix/move-modal

Conversation

@andrinoff

Copy link
Copy Markdown
Member

What?

Uses overlay.Center for the move modal.

Why?

The previous version messed with the inbox contents on both sides. Like in #1435

Signed-off-by: drew <me@andrinoff.com>
@andrinoff
andrinoff requested a review from a team as a code owner June 4, 2026 19:15

@floatpanebot floatpanebot left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @andrinoff! Please fix the following issues with your PR:

  • Title: Is too long (42 characters). The PR title must be strictly under 40 characters.

@floatpanebot floatpanebot added bug Something isn't working area/tui Terminal UI / view layer size/S Diff: 11–50 lines labels Jun 4, 2026
@andrinoff andrinoff changed the title fix(ui): use overlay.Center for move modal fix(ui): use overlay for move modal Jun 4, 2026
@floatpanebot
floatpanebot dismissed their stale review June 4, 2026 19:16

Formatting issues have been resolved. Thank you!

@floatpanebot floatpanebot added the backport/v1 Merge to master and backport to release/v1 label Jun 4, 2026
@andrinoff
andrinoff requested a review from steveevansdev June 4, 2026 19:17

@steveevansdev steveevansdev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@steveevansdev
steveevansdev added this pull request to the merge queue Jun 4, 2026
Merged via the queue into floatpane:master with commit c090aa6 Jun 4, 2026
35 of 36 checks passed
@floatpanebot floatpanebot added the backport-failed Cherry-pick conflict — needs manual backport label Jun 4, 2026
@floatpane floatpane deleted a comment from andrinoff Jun 4, 2026
andrinoff added a commit that referenced this pull request Jun 4, 2026
Uses `overlay.Center` for the move modal.

The previous version messed with the inbox contents on both sides. Like
in #1435

Signed-off-by: drew <me@andrinoff.com>
(cherry picked from commit c090aa6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/tui Terminal UI / view layer backport/v1 Merge to master and backport to release/v1 backport-failed Cherry-pick conflict — needs manual backport bug Something isn't working size/S Diff: 11–50 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants