Repository navigation
feat(cli): add mail manage commands - #1755
Open
Robin-Everaars wants to merge 5 commits into
Open
Robin-Everaars wants to merge 5 commits into
Robin-Everaars wants to merge 5 commits into
Conversation
Add `matcha folders [--from <email>] [--json]`, the first read-only mail command next to `send`. The shared plumbing for the follow-up commands lives in cli/util.go (account resolution by --from, matching Email and then FetchEmail case-insensitively) and cli/main.go (hookable config loader, service constructor and output writers for tests). daemonclient gains NewCLIClient(cfg, autoStart). With autoStart off, a one-shot command uses a running daemon and otherwise connects directly instead of forking a daemon. NewService keeps its behaviour. Refs floatpane#1642
Add `matcha list [folder] [--from <email>] [--json]`, which prints the newest 50 messages of a folder (INBOX by default) as a table or as JSON with uid, from, subject, date and is_read. Adds the helpers the later read, search and manage commands share: INBOX normalization, flag parsing that allows flags after positionals, and the table/JSON email renderer. Refs floatpane#1642
Add `matcha read [--from <email>] [--json] <folder> <uid>`. A single numeric argument reads that UID from INBOX. Plain output prints the body; --json returns body, mime_type and attachment metadata. backend.Attachment gets explicit snake_case JSON names, and its raw Data bytes are excluded so scripts never receive the payload as base64. Refs floatpane#1642
Add `matcha search [--from <email>] [--json] <folder> <query>`, using the same query syntax as the TUI (from:, to:, subject:, body:, since:, before:, larger:). Unquoted terms after the folder are joined, so `matcha search INBOX from:a subject:b` keeps both terms. Search was not reachable through the service layer yet, so this adds Search to daemonclient.Service (daemon and direct), a Search RPC method and its daemon handler. The daemon gets the raw query and parses it itself. Refs floatpane#1642
Add the mail-managing subcommands: matcha archive [--from <email>] <folder> <uids> matcha delete [--from <email>] <folder> <uids> matcha mark-read [--from <email>] <folder> <uids> matcha mark-unread [--from <email>] <folder> <uids> matcha move [--from <email>] <src> <dst> <uids> UIDs are comma- or space-separated. They share one implementation, so they come as one change. The daemon's MarkRead handler logged per-UID failures but still reported success over RPC, so `mark-read` through a running daemon said it worked when it did not. It now returns the joined errors, like the other mutating handlers and direct mode. Refs floatpane#1642
This was referenced Oct 27, 2026
floatpanebot
added
target/v1
Member
|
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
floatpanebot
added
bug
floatpanebot
previously requested changes
Oct 27, 2026
floatpanebot
left a comment
floatpanebot
left a comment
Member
There was a problem hiding this comment.
Hi @Robin-Everaars! Please fix the following issues with your PR:
- Title: Is too long (42 characters). The PR title must be strictly under 40 characters.
floatpanebot
previously requested changes
Oct 27, 2026
floatpanebot
left a comment
floatpanebot
left a comment
Member
There was a problem hiding this comment.
Hi @Robin-Everaars! Please fix the following issues with your PR:
- Title: Is too long (42 characters). The PR title must be strictly under 40 characters.
Robin-Everaars
changed the title
floatpanebot
dismissed stale reviews from themself
October 27, 2026 23:00
Formatting issues have been resolved. Thank you!
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Adds the commands that change mail:
UIDs are comma- or space-separated. The five share one implementation, so they come in one PR.
Also a fix: the daemon's MarkRead handler logged failures per UID but still reported success over RPC, so
mark-readthrough a running daemon said it worked when it didn't. It now returns the joined errors, like the other mutating handlers and direct mode.Why?
Closes #1642 together with the earlier PRs. Depends on #1754.
This is one of five small PRs that replace #1680, as asked there: rebuilt on
release/v1and split per command. They stack, so please merge them in order. Each one shows its predecessors' commits until those are merged.Every step passes
gofmt,go vet,go test ./...,go mod tidyand golangci-lint on the new code.