Skip to content

Make NativePHPHash singleton#2519

Merged
norberttech merged 2 commits into
flow-php:1.xfrom
stloyd:chore/perf-php-hash
Jul 11, 2026
Merged

Make NativePHPHash singleton#2519
norberttech merged 2 commits into
flow-php:1.xfrom
stloyd:chore/perf-php-hash

Conversation

@stloyd

@stloyd stloyd commented Jul 11, 2026

Copy link
Copy Markdown
Member

Running benchmark with 1M iterations:

NativePHPHash::xxh128() non-static 0.5040 seconds
NativePHPHash::xxh128() static 0.2383 seconds
new NativePHPHash()->hash() ask for algorithms 0.7743 seconds
new NativePHPHash()->hash() re-use algorithms 0.4724 seconds

Resolves: #xxx

Change Log


Added

Fixed

Changed

  • Make `NativePHPHash` singleton

Removed

Deprecated

Security

@codecov

codecov Bot commented Jul 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.96%. Comparing base (b671d90) to head (bf18abb).
⚠️ Report is 3 commits behind head on 1.x.

Additional details and impacted files
@@             Coverage Diff              @@
##                1.x    #2519      +/-   ##
============================================
  Coverage     85.96%   85.96%              
- Complexity        0    22258   +22258     
============================================
  Files          1663     1663              
  Lines         68406    68408       +2     
============================================
+ Hits          58807    58810       +3     
+ Misses         9599     9598       -1     
Components Coverage Δ
etl 88.55% <100.00%> (+<0.01%) ⬆️
cli 89.40% <ø> (ø)
lib-array-dot 81.44% <ø> (ø)
lib-azure-sdk 64.44% <ø> (ø)
lib-doctrine-dbal-bulk 93.61% <ø> (ø)
lib-filesystem 85.97% <ø> (ø)
lib-types 90.16% <ø> (ø)
lib-parquet 70.10% <ø> (ø)
lib-parquet-viewer 82.26% <ø> (ø)
lib-snappy 89.38% <ø> (+0.44%) ⬆️
lib-dremel 0.00% <ø> (ø)
lib-postgresql 88.62% <ø> (ø)
lib-telemetry 86.58% <ø> (ø)
bridge-filesystem-async-aws 92.74% <ø> (ø)
bridge-filesystem-azure 90.45% <ø> (ø)
bridge-monolog-http 96.82% <ø> (ø)
bridge-monolog-telemetry 94.79% <ø> (ø)
bridge-openapi-specification 92.07% <ø> (ø)
symfony-http-foundation 78.57% <ø> (ø)
bridge-psr18-telemetry 100.00% <ø> (ø)
bridge-psr3-telemetry 98.95% <ø> (ø)
bridge-psr7-telemetry 100.00% <ø> (ø)
bridge-telemetry-otlp 90.41% <ø> (ø)
bridge-symfony-http-foundation-telemetry 92.85% <ø> (ø)
bridge-symfony-filesystem-bundle 90.66% <ø> (ø)
bridge-symfony-filesystem-cache 98.18% <ø> (ø)
bridge-symfony-postgresql-bundle 93.39% <ø> (ø)
bridge-symfony-postgresql-cache 94.41% <ø> (ø)
bridge-symfony-postgresql-messenger 98.80% <ø> (ø)
bridge-symfony-postgresql-session 93.65% <ø> (ø)
bridge-symfony-telemetry-bundle 90.23% <ø> (ø)
adapter-chartjs 84.05% <ø> (ø)
adapter-csv 91.43% <ø> (ø)
adapter-doctrine 90.79% <ø> (ø)
adapter-google-sheet 99.18% <ø> (ø)
adapter-http 72.34% <ø> (ø)
adapter-json 88.71% <ø> (ø)
adapter-logger 50.00% <ø> (ø)
adapter-parquet 77.70% <ø> (ø)
adapter-text 74.13% <ø> (ø)
adapter-xml 83.40% <ø> (ø)
adapter-avro 0.00% <ø> (ø)
adapter-excel 94.21% <ø> (ø)
adapter-postgresql 91.06% <ø> (ø)
adapter-seal 85.42% <ø> (ø)
bridge-phpunit-postgresql 75.30% <ø> (ø)
bridge-phpunit-telemetry 87.32% <ø> (ø)
bridge-phpstan-types 0.00% <ø> (ø)
bridge-postgresql-valinor 100.00% <ø> (ø)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@norberttech norberttech marked this pull request as ready for review July 11, 2026 10:10
@norberttech norberttech self-requested a review as a code owner July 11, 2026 10:10
@norberttech norberttech merged commit 6d8d9d5 into flow-php:1.x Jul 11, 2026
40 checks passed
@stloyd stloyd deleted the chore/perf-php-hash branch July 11, 2026 10:39
@norberttech norberttech added the hackaton-07-2026 A first Flow Hackaton with Stloyd and MrHDOLEK 🎉 label Jul 11, 2026
@norberttech norberttech added this to the 0.42.0 milestone Jul 11, 2026
@github-project-automation github-project-automation Bot moved this from Todo to Done in Roadmap Jul 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hackaton-07-2026 A first Flow Hackaton with Stloyd and MrHDOLEK 🎉 size: XS

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants