Skip to content

Change API for sendMessageRaw on CommandSender to have ChatReceiver #2

Description

@Zidane

Would be nice to always have the ChatReceiver parameter in the sendMessageRaw method (one of the other two sendMessage messages has it). If null is passed in to it, that's fine as its up to lib users to handle what happens in that situation.


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Activity

  1. changed the title [-]Change API for sendMessage on CommandSender to always have ChatReceiver[/-] [+]Change API for sendMessageRaw on CommandSender to have ChatReceiver[/+] on Jul 10, 2014
  2. Zidane commented on Jul 10, 2014

    @Zidane
    Author

    To clarify

    tl;dr I just want sendMessageRaw(ChatReceiver from, String message)

  3. Wolf480pl commented on Jul 10, 2014

    @Wolf480pl
    Contributor

    The plan was that there's some pattern/format mechanism (coming "soon") called in ChatReceiver.sendMessage(ChatReceiver,String) and ChatChannel.broadcast(ChatReceiver,String) and uses something like "<{sender}> {msg}" to create the message that will be sent to the client via sendMessageRaw.

    But now that I think of it, it might be a good idea to pass the sender further. What's exactly your use case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions