Enable flutter engine artifacts for Windows on Arm #115983

Activity

1. danagbemava-nc

   added

   in triagePresently being triaged by the triage teamPresently being triaged by the triage team

   c: new featureNothing broken; request for a new capabilityNothing broken; request for a new capability

   engineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.

   platform-windowsBuilding on or for Windows specificallyBuilding on or for Windows specifically

   platform-host-armBuilding on an ARM-based platformBuilding on an ARM-based platform

   and removed

   in triagePresently being triaged by the triage teamPresently being triaged by the triage team

   on Nov 25, 2022
2. chinmaygarde

   added

   P3Issues that are less important to the Flutter projectIssues that are less important to the Flutter project

   on Nov 28, 2022
3. p-b-o commented on Dec 1, 2022

   

   p-b-o

   on Dec 1, 2022

   ContributorAuthor

   More actions

   @loic-sharma Tried to create a gerrit change for that, but it confirms I don't have access.

   The commit to upstream is here, based on what was done for darwin-arm64.
4. loic-sharma commented on Dec 6, 2022

   

   loic-sharma

   on Dec 6, 2022

   Member

   More actions

   Hello, thanks for the patch! I apologize for the delay, I was off last week.

   I kicked off a test run of your changes, that failed on the Zip windows-arm64 windows-arm64-embedder.zip step:

   IOError: [Errno 2] No such file or directory: u'C:\b\s\w\ir\cache\builder\src\out/host_debug_arm64/flutter_embedder.h'

   Please let me know when you're ready for me to run another test!
5. p-b-o commented on Dec 6, 2022

   

   p-b-o

   on Dec 6, 2022

   ContributorAuthor

   More actions

   Thanks @loic-sharma . No problem, you said you were out :)

   I pushed two other commits here, to fix the issue you mentioned (regarding font), and removed the embedder package for now (not sure what it is used for).

   Feel free to squash commits to have a single patch. For now, I just try to keep commits splitted to track history of this patch.

   👍React with 👍1Reacted by Loïc Sharma
6. loic-sharma commented on Dec 6, 2022

   

   loic-sharma

   on Dec 6, 2022

   Member

   More actions

   Here's the latest result: https://ci.chromium.org/raw/build/logs.chromium.org/flutter/led/loicsharma_google.com/c0e4ff1860fc1c4916a177502cc4cfb0fad1d20aa848aac5b68add72334199f0/+/build.proto?server=chromium-swarm.appspot.com

   ( 321 ms )C:\b\s\w\ir\cache\builder\src\out\host_release_arm64\zip_archives\windows-arm64\font-subset.zip not found
   ( 319 ms )Files in parent directory of safe_upload request
   [WinError 3] The system cannot find the path specified: 'C:\b\s\w\ir\cache\builder\src\out\host_release_arm64\zip_archives\windows-arm64'
7. p-b-o commented on Dec 7, 2022

   

   p-b-o

   on Dec 7, 2022

   Last edited by p-b-o

   ContributorAuthor

   More actions

   I removed the font subset as it does not seem to be built when building for windows-arm64. Still here.
8. loic-sharma commented on Dec 7, 2022

   

   loic-sharma

   on Dec 7, 2022

   Member

   More actions

   Here's the latest build: https://ci.chromium.org/raw/build/logs.chromium.org/flutter/led/loicsharma_google.com/b765281e408ff608bc165ac7291626f93782efeac52f2d4936eb64a7482f9847/+/build.proto?server=chromium-swarm.appspot.com

   It looks like it passed! (The final step fails, but that seems like an unrelated permission issue)
9. p-b-o commented on Dec 8, 2022

   

   p-b-o

   on Dec 8, 2022

   Last edited by p-b-o

   ContributorAuthor

   More actions

   Ok great! I squashed all commits, and rebased it on top of master.

   Could you submit it for review please, and post the link here?

   👍React with 👍1Reacted by Loïc Sharma
10. loic-sharma commented on Dec 9, 2022

    

    loic-sharma

    on Dec 9, 2022

    Member

    More actions

    Here's the changelist: https://flutter-review.git.corp.google.com/c/recipes/+/37085

    FYI there will be an infrastructure freeze from December 20th to January 4th due to the holidays. That might affect your ARM64 work.
11. loic-sharma commented on Dec 9, 2022

    

    loic-sharma

    on Dec 9, 2022

    Member

    More actions

    FYI, @godofredoc left a comment that you will also need to modify this: https://github.com/flutter/engine/tree/main/ci/builders
12. godofredoc commented on Dec 9, 2022

    

    godofredoc

    on Dec 9, 2022

    Contributor

    More actions

    Public link to CL: https://flutter-review.googlesource.com/c/recipes/+/37085

    ❤️React with ❤️1Reacted by Loïc Sharma
13. p-b-o commented on Dec 9, 2022

    

    p-b-o

    on Dec 9, 2022

    ContributorAuthor

    More actions

    Thanks, I'll answer on CL from now.
14. p-b-o commented on Dec 16, 2022

    

    p-b-o

    on Dec 16, 2022

    ContributorAuthor

    More actions

    From CL, it appears the "recipes" approach will be dropped in favor of a new solution, directly integrated in flutter engine repo, from January 2023. Thus, this seems to be the best approach at that time, and I'll do a PR for that.

    👍React with 👍1Reacted by Loïc Sharma
15. p-b-o commented on Dec 19, 2022

    

    p-b-o

    on Dec 19, 2022

    ContributorAuthor

    More actions

    Created PR on engine to add support for arm64 artifacts.
16. loic-sharma

    closed this as completedon Jun 29, 2023
17. danagbemava-nc

    added

    r: fixedIssue is closed as already fixed in a newer versionIssue is closed as already fixed in a newer version

    on Jun 30, 2023
18. github-actions commented on Jul 14, 2023

    

    github-actionsBot

    on Jul 14, 2023

    More actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.
19. github-actions

    locked as resolved and limited conversation to collaborators on Jul 14, 2023