Skip to content

fix: Fix error messages format received from HoldingsIQ#691

Merged
viacheslavkol merged 1 commit into
masterfrom
MODKBEKBJ-826
Jun 30, 2026
Merged

fix: Fix error messages format received from HoldingsIQ#691
viacheslavkol merged 1 commit into
masterfrom
MODKBEKBJ-826

Conversation

@viacheslavkol

@viacheslavkol viacheslavkol commented Jun 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Purpose

Fix error messages format received from HoldingsIQ

Approach

Format messages when they have invalid structure

Changes Checklist

  • API Changes: Document any API paths, methods, request or response bodies changed, added, or removed.
  • Database Schema Changes: Indicate any database schema changes and their impact. Confirm that migration scripts were created.
  • Interface Version Changes: Indicate any changes to interface versions.
  • Interface Dependencies: Document added or removed dependencies.
  • Permissions: Document any changes to permissions.
  • Logging: Confirm that logging is appropriately handled.
  • Unit Testing: Confirm that changed classes were covered by unit tests.
  • Integration Testing: Confirm that changed logic was covered by integration tests.
  • Manual Testing: Confirm that changes were tested on local or dev environment.
  • NEWS: Confirm that the NEWS file is updated with relevant information about the changes made in this pull request.

Related Issues

MODKBEKBJ-826

Screenshots (if applicable)

image

@viacheslavkol viacheslavkol self-assigned this Jun 30, 2026
@sonarqubecloud

sonarqubecloud Bot commented Jun 30, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
88.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@viacheslavkol viacheslavkol marked this pull request as ready for review June 30, 2026 09:01
@viacheslavkol viacheslavkol requested a review from a team as a code owner June 30, 2026 09:01
psmagin
psmagin approved these changes Jun 30, 2026
View reviewed changes

@psmagin psmagin left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's worth to mention this strange message format to holdingsiq team

@viacheslavkol viacheslavkol merged commit 58900ed into master Jun 30, 2026
16 checks passed
@viacheslavkol viacheslavkol deleted the MODKBEKBJ-826 branch June 30, 2026 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@psmagin psmagin psmagin approved these changes
@SvitlanaKovalova1 SvitlanaKovalova1 SvitlanaKovalova1 approved these changes

Assignees

@viacheslavkol viacheslavkol

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@viacheslavkol @psmagin @SvitlanaKovalova1