Repository navigation
fix(window): show launch logs for ephemeral windows and stop them getting stuck - #129
Merged
Merged
Conversation
…ting stuck (#128) An ephemeral window that never receives a MetaWindow kept `metaWindowId` null: its close button called `WindowProviderMixin.closeWindow()`, which only closes owned native windows, so with none it did nothing and the tile stayed as a blank, unclosable card. - Render a dark terminal container with the launch's execution logs (and a close button) while an ephemeral window waits for its surface, instead of an empty `Container()`. `LogsViewer` gains an optional `textColor` so the transcript stays legible on the dark background. - `EphemeralWindowState.closeWindow` removes the tile when it owns no native window, mirroring `PersistentWindowState`. - Cancel a pending launch when a Persistent/Ephemeral tile is removed: a tile that displayed a window is left to exit through its window, while a tile still waiting on its first surface stops its tracked `veshell-launch-*.service` unit (`systemctl --user stop`). `AppLaunch` records each launch, marks it once a window is attributed, and leaves a unit whose window is displayed under another tile running. - Add a regression test for the close/remove + pending-launch cancellation.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the stuck/blank ephemeral window from #128.
An
EphemeralWindowthat never receives aMetaWindowkeepsmetaWindowId == null. Its close button calledWindowProviderMixin.closeWindow(), which only closes owned native windows — with none it did nothing — and the widget rendered an emptyContainer(). The result was a blank card that could not be closed and stayed until compositor restart.Changes
Waiting state is now readable and closable
EphemeralWindowWidgetrenders a dark terminal container with the launch's execution logs whilemetaWindowId == null(a progress indicator until the launcher returns), plus a close button. No more blank card.LogsViewergains an optionaltextColorso the transcript/cursor stay legible on the dark background (default unchanged).EphemeralWindowcarries the launchedpid;EphemeralWindowState.launchSelfrecords it.Closing can no longer get stuck
EphemeralWindowState.closeWindowremoves the tile when it owns no native window, mirroringPersistentWindowState.Cancel a pending launch when a tile is removed
AppLaunchnow records each tracked launch (supervisor process +veshell-launch-*.serviceunit), marks a launch once a native window is attributed to the tile, and drops the record when the supervisor exits.cancelPendingLaunch: if the launch never produced a window it is stopped viasystemctl --user stop(SIGTERM to the cgroup — killing thesystemd-runsupervisor would not stop the service). The untracked fallback kills the shell-owned process.Tests / verification
src/shell/test/ephemeral_window_close_test.dart: closing a waiting ephemeral window removes it and cancels its pending launch.flutter test— 448 passed.flutter build linux --debug✓,cargo check✓,cargo fmt --check✓.Notes
docs/design/file_explorer_ephemeral_launch.md).Closes #128.