Skip to content

fix(packaging): don't quote the session Exec path (SDDM/plasmalogin) - #153

Merged
PapyElGringo merged 1 commit into
mainfrom
fix/session-desktop-exec-quoting
Oct 16, 2026
Merged

PapyElGringo merged 1 commit into
mainfrom
fix/session-desktop-exec-quoting

Conversation

@PapyElGringo

Copy link
Copy Markdown
Contributor

Problem

Installing Veshell on a Fedora Kinoite VM and selecting it at the login screen bounces straight back to the greeter. The session wrapper's log shows why:

/etc/plasmalogin/wayland-session: line 49:
  /var/home/papyelgrigno/"/usr/bin/veshell-session": No such file or directory

The installed desktop entry is Exec="/usr/bin/veshell-session". GDM parses the Exec field per the desktop-entry spec and strips the quotes, but SDDM — and plasmalogin, its Plasma Login Manager successor — pass the raw field to wayland-session, which ends in exec $@. The literal quotes turn the absolute path into a relative one, so exec fails with status 127 before Veshell ever runs:

plasmalogin-helper: Starting Wayland user session: "/etc/plasmalogin/wayland-session" "\"/usr/bin/veshell-session\""
plasmalogin[1021]: Auth: plasmalogin-helper exited with 127

This is a regression from the packaging overhaul (36b7924, Oct 5) that shipped in 0.1.4; earlier releases used the bare Exec=veshell-session, which SDDM resolved through PATH.

Fix

Emit the Exec path unquoted. It stays absolute (so a Nix store prefix still works), and no install prefix contains a space. This matches the unquoted Exec that GNOME (Exec=/usr/bin/gnome-session) and Plasma ship.

The packaging test's expectations are updated, and a guard rejects a reintroduced Exec=".

Verification

On the Fedora Kinoite 44 VM (plasmalogin + KWin greeter, veshell-bin-0.1.4):

  • Before: selecting Veshell → plasmalogin-helper exited with 127 → back to the login screen, no Veshell logs at all.
  • After editing the installed entry to Exec=/usr/bin/veshell-session: the session starts — veshell.service is active (running), Main PID: veshell --session, and the compositor renders its UI.

bash extra/tests/packaging_install.sh passes.

Note

This is the actual cause of the SDDM/KDE login failure. It is independent of #131 (which hardens backend selection and retries the DRM-master handoff); the race in that PR did occur here (kwin_wayland: atomic commit failed: Permission denied) but did not prevent the session from starting, so #131 is hardening, not the fix.

The installed veshell.desktop wrapped the session path in double quotes
(Exec="/usr/bin/veshell-session"). GDM parses the Exec field per the
desktop-entry spec and strips the quotes, but SDDM — and plasmalogin, its
Plasma Login Manager successor — hand the raw field to the wayland-session
script, which ends in `exec $@`. The literal quotes make the path relative,
so the session dies before the compositor starts:

  /etc/plasmalogin/wayland-session: line 49:
    /var/home/<user>/"/usr/bin/veshell-session": No such file or directory

plasmalogin then reports `plasmalogin-helper exited with 127` and bounces
back to the login screen. The regression came with the packaging overhaul
(36b7924) and shipped in 0.1.4; earlier releases used the bare command name.

Drop the quotes. The path stays absolute, so a Nix store prefix still works,
and no install prefix contains a space. This matches the unquoted Exec that
GNOME and Plasma ship. A test guard rejects a reintroduced `Exec="`.

Verified on Fedora Kinoite 44 (plasmalogin + KWin greeter): with the quotes
the Veshell session returns to the login screen; without them it starts
(veshell.service active, compositor rendering).
@PapyElGringo
PapyElGringo merged commit e243152 into main Oct 16, 2026
2 checks passed
@PapyElGringo
PapyElGringo deleted the fix/session-desktop-exec-quoting branch October 16, 2026 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant