Repository navigation
fix(packaging): don't quote the session Exec path (SDDM/plasmalogin) - #153
Merged
Merged
Conversation
The installed veshell.desktop wrapped the session path in double quotes
(Exec="/usr/bin/veshell-session"). GDM parses the Exec field per the
desktop-entry spec and strips the quotes, but SDDM — and plasmalogin, its
Plasma Login Manager successor — hand the raw field to the wayland-session
script, which ends in `exec $@`. The literal quotes make the path relative,
so the session dies before the compositor starts:
/etc/plasmalogin/wayland-session: line 49:
/var/home/<user>/"/usr/bin/veshell-session": No such file or directory
plasmalogin then reports `plasmalogin-helper exited with 127` and bounces
back to the login screen. The regression came with the packaging overhaul
(36b7924) and shipped in 0.1.4; earlier releases used the bare command name.
Drop the quotes. The path stays absolute, so a Nix store prefix still works,
and no install prefix contains a space. This matches the unquoted Exec that
GNOME and Plasma ship. A test guard rejects a reintroduced `Exec="`.
Verified on Fedora Kinoite 44 (plasmalogin + KWin greeter): with the quotes
the Veshell session returns to the login screen; without them it starts
(veshell.service active, compositor rendering).
This was referenced Oct 16, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Installing Veshell on a Fedora Kinoite VM and selecting it at the login screen bounces straight back to the greeter. The session wrapper's log shows why:
The installed desktop entry is
Exec="/usr/bin/veshell-session". GDM parses theExecfield per the desktop-entry spec and strips the quotes, but SDDM — and plasmalogin, its Plasma Login Manager successor — pass the raw field towayland-session, which ends inexec $@. The literal quotes turn the absolute path into a relative one, soexecfails with status 127 before Veshell ever runs:This is a regression from the packaging overhaul (
36b7924, Oct 5) that shipped in 0.1.4; earlier releases used the bareExec=veshell-session, which SDDM resolved throughPATH.Fix
Emit the
Execpath unquoted. It stays absolute (so a Nix store prefix still works), and no install prefix contains a space. This matches the unquotedExecthat GNOME (Exec=/usr/bin/gnome-session) and Plasma ship.The packaging test's expectations are updated, and a guard rejects a reintroduced
Exec=".Verification
On the Fedora Kinoite 44 VM (plasmalogin + KWin greeter,
veshell-bin-0.1.4):plasmalogin-helper exited with 127→ back to the login screen, no Veshell logs at all.Exec=/usr/bin/veshell-session: the session starts —veshell.serviceisactive (running),Main PID: veshell --session, and the compositor renders its UI.bash extra/tests/packaging_install.shpasses.Note
This is the actual cause of the SDDM/KDE login failure. It is independent of #131 (which hardens backend selection and retries the DRM-master handoff); the race in that PR did occur here (
kwin_wayland: atomic commit failed: Permission denied) but did not prevent the session from starting, so #131 is hardening, not the fix.