Repository navigation
fix: update benchmark command - #1631
Merged
Merged
Conversation
|
⏳ Running benchmarks and calculating weights. DO NOT MERGE! A new commit will be added upon completion... |
Collaborator
|
additional reference: paritytech/substrate#11637 |
|
✅ Finished running benchmarks. Updated weights have been committed to this PR branch in commit 2907038. |
github-actions
Bot
added
the
metadata-changed
wilwade
approved these changes
Jul 7, 2023
github-actions
Bot
added
metadata-changed
JoeCap08055
approved these changes
Jul 10, 2023
JoeCap08055
left a comment
JoeCap08055
left a comment
Collaborator
There was a problem hiding this comment.
Do we need to update the spec_version just because weights were updated? Otherwise lgtm.
Collaborator
Author
|
Yes, after the weights were updated, the metadata-mismatch test triggered. |
shannonwells
pushed a commit
that referenced
this pull request
Apr 16, 2024
# Goal The goal of this PR is to update the benchmark command with an additional argument `--additional-trie-layers=20`. Closes #1630 # Discussion Due to changes in Polkadot v0.9.38, it is recommended to update the benchmark command. # Checklist - [x] Chain spec updated - [ ] Custom RPC OR Runtime API added/changed? Updated js/api-augment. - [ ] Design doc(s) updated - [ ] Tests added - [ ] Benchmarks added - [x] Weights updated --------- Co-authored-by: Frequency CI [bot] <do-not-reply@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
The goal of this PR is to update the benchmark command with an additional argument
--additional-trie-layers=20.Closes #1630
Discussion
Due to changes in Polkadot v0.9.38, it is recommended to update the benchmark command.
Checklist