Skip to content

MusicXML: Fix slurs over bars and voices#81

Merged
PeterBjuhr merged 7 commits into
frescobaldi:masterfrom
eoma:fix-slurs-over-bars-and-voices
May 10, 2018
Merged

MusicXML: Fix slurs over bars and voices#81
PeterBjuhr merged 7 commits into
frescobaldi:masterfrom
eoma:fix-slurs-over-bars-and-voices

Conversation

@eoma

@eoma eoma commented Feb 14, 2017

Copy link
Copy Markdown
Contributor

These changes should make it possible keep slurs over multiple bars and merge other voices with slurs in a ScoreSection.

Tests are added, but the test script must be modified (not pushed here) in order to run on my machine (Ubuntu 16.10, python 3.5).

@wbsoft

wbsoft commented Feb 15, 2017

Copy link
Copy Markdown
Collaborator

Thank you! @PeterBjuhr can you comment?
Just a little question of mine: why can't the SlurCount simply be an integer, using +=1 and -=1 to maintain the count? It seems overkill to use a SlurCount object with inc and dec methods. But maybe you want to extend SlurCount's functionality later?

@eoma

eoma commented Feb 15, 2017

Copy link
Copy Markdown
Contributor Author

SlurCount can't be an integer due to python's pass by value (copy). This means it's not possible to just pass along an integer expecting the function to modify it by reference, the alternative would be to modify and return the modified value. By using an object instance, only the pointer is copied, but I can still modify the instance.

I could remove the inc and dec methods, and just make its users modify count directly.

@wbsoft

wbsoft commented Feb 15, 2017

Copy link
Copy Markdown
Collaborator

Ah, that's clear! No it's perfectly to keep it, then. As @PeterBjuhr is the MusicXML man, I'll wait his response ;)

@eoma eoma force-pushed the fix-slurs-over-bars-and-voices branch from c669a81 to 0944201 Compare February 17, 2017 09:27
@eoma

eoma commented Feb 17, 2017

Copy link
Copy Markdown
Contributor Author

Rebased against latest release

@eoma eoma force-pushed the fix-slurs-over-bars-and-voices branch from 0944201 to 123e9e5 Compare February 18, 2017 12:12
@eoma eoma changed the title Fix slurs over bars and voices MusicXML: Fix slurs over bars and voices Feb 20, 2017
@eoma

eoma commented Feb 20, 2017

Copy link
Copy Markdown
Contributor Author

I've added phrasing indication to the slur object.
This will later be useful for aligning lyrics to melody.

@eoma eoma force-pushed the fix-slurs-over-bars-and-voices branch from 9d5d7bb to 681854b Compare February 20, 2017 17:51
@eoma eoma force-pushed the fix-slurs-over-bars-and-voices branch from 681854b to 6e04012 Compare March 28, 2017 20:09
@eoma

eoma commented Apr 26, 2017

Copy link
Copy Markdown
Contributor Author

Any update on this?

@uliska

uliska commented May 7, 2018

Copy link
Copy Markdown
Collaborator

I've merged master into this branch to fix a merge conflict.

Looking at the test files and briefly on the code I don't see anything that speaks against merging this, @PeterBjuhr

@PeterBjuhr PeterBjuhr merged commit 0d91ca2 into frescobaldi:master May 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants