Skip to content

Better setup for android build version. - #67

Merged
maicki merged 2 commits into
frostney:masterfrom
hyochan:master
Sep 16, 2018
Merged

maicki merged 2 commits into
frostney:masterfrom
hyochan:master

Conversation

@hyochan

@hyochan hyochan commented Jul 15, 2018 •

Copy link
Copy Markdown
Contributor

React Native now has its project set up with default build version of androids sdk. Set android build version to that of rootProject’s to prevent from build failing cause of version mismatch.

React Native now has its project set up with default build version of androids sdk. Set android build version to that ofrootProjet``s to prevent from build failing cause of version mismatch.
@maicki
maicki requested a review from thorbenprimke August 24, 2018 07:40
@maicki

maicki commented Aug 24, 2018

Copy link
Copy Markdown
Contributor

@thorbenprimke Could you please take a look at this PR? Thanks!

Support older react-native version.
@hyochan

hyochan commented Aug 24, 2018

Copy link
Copy Markdown
Contributor Author

@maicki @thorbenprimke I just got notified and I updated code safer.

@maicki

maicki commented Sep 15, 2018

Copy link
Copy Markdown
Contributor

@dooboolab Hey - I would like to go forward with this, just some small improvements before landing. Can you extract setting the version via a function like:

def safeExtGet(prop, fallback) {
     rootProject.ext.has(prop) ? rootProject.ext.get(prop) : fallback
 }

and set each value like:

// ...
compileSdkVersion safeExtGet('compileSdkVersion', DEFAULT_COMPILE_SDK_VERSION)
// ...

@maicki maicki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM let's get it in and approve on top

@maicki
maicki merged commit 0b78730 into frostney:master Sep 16, 2018
@hyochan

hyochan commented Sep 16, 2018

Copy link
Copy Markdown
Contributor Author

@maicki Someone already gave PR on this one. Thanks for the merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants