Repository navigation
Better setup for android build version. - #67
Merged
Merged
Conversation
React Native now has its project set up with default build version of androids sdk. Set android build version to that ofrootProjet``s to prevent from build failing cause of version mismatch.
rnagella
approved these changes
Aug 20, 2018
Contributor
|
@thorbenprimke Could you please take a look at this PR? Thanks! |
Support older react-native version.
Contributor
Author
|
@maicki @thorbenprimke I just got notified and I updated code safer. |
Contributor
|
@dooboolab Hey - I would like to go forward with this, just some small improvements before landing. Can you extract setting the version via a function like: and set each value like: |
maicki
approved these changes
Sep 16, 2018
maicki
left a comment
Contributor
There was a problem hiding this comment.
LGTM let's get it in and approve on top
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
React Native now has its project set up with default build version of androids sdk. Set android build version to that of rootProject’s to prevent from build failing cause of version mismatch.