Repository navigation
Sign assemblies with strong name key file - #1386
Merged
Merged
Conversation
Contributor
Author
|
I attempted to use public signing, but ran into a similar issue to this: dotnet/machinelearning#600 (comment) If you would prefer having the snk file somewhere else, let me know and I'll gladly move it to it's appropriate location. |
Contributor
|
See comment here, #1235 (comment) |
dsyme
approved these changes
Jul 27, 2021
Contributor
Author
|
Thank you for merging. The reason for the strong naming is that our .netstandard project was recently integrated into one of our products. It's a plugin for an older system that only supports .Net framework and assemblies have to be signed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #990 and #1235