Repository navigation
Fix html parsing for incomplete tags - #1396
Merged
Merged
Conversation
cartermp
approved these changes
Oct 13, 2021
cartermp
left a comment
cartermp
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @albert-du - will merge and release subject to CI passing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix for #1394
If the last tag of an html string wasn't closed with
>, it would get stuck in an infinite loop. Adding pattern match cases forEOFthat close the tag normally fixes it.also added a test